Always run database setup during startup #3638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentdr
force-pushed
the
document-expiration-fix
branch
from
0602628 to
7799e30
Compare
bording
approved these changes
Jul 19, 2023
kentdr
changed the title
kentdr
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the audit database (RavenDB 5) is deleted after installation through SCMU, the next time the audit service starts, the DB will be recreated with the document expiration setting turned off and the indexes are not recreated. In addition to the missing indexes causing errors at runtime, this will also cause message audit documents to accumulate and not be deleted at their configured retention time.
This PR ensures that the database setup routine is always run to ensure indexes are created, and the document expiration feature is always enabled.