Refactored settings handling by ramonsmits · Pull Request #3682 · Particular/ServiceControl

First revision with commented code in implementation regarding settings validation

ramonsmits

committed

Validating some settings values at persister creation and setting default values on settings type

ramonsmits

committed

PersisterSettings converted into marker interface to that at runtime the persister specific settings can serialized to JSON for diagnostics output in the REST API

ramonsmits

committed

Refactorings on SettingsReader

ramonsmits

committed

⚜️ Code readability

ramonsmits

committed

🔨 Settings readers now using `TypeDescriptor.GetConverter` as `Convert.ChangeType` can't convert to TimeSpan and now supports TryRead on on SettingsReader to deal with non-nulleable types

ramonsmits

committed

⚜️ Improved readability of free/total storage log entries

ramonsmits

committed

`PersistenceFactory.Create` now only takes a dependency on `Settings` which has its `PersisterSettings property change from Dictionary to IPersisterSettings. This allows for a persister specific im…

ramonsmits

committed

small tweaks

tmasternak

authored and

ramonsmits

committed

⚜️Code readability

ramonsmits

committed

🔨 Removed settings from app config by extending settings constructor with optional arguments for these and have the test runner pass explicit values for these removing the need to copy settings ru…

ramonsmits

committed

🩹 Fix test, specify required setting values

ramonsmits

committed

fixing maintenance mode startup

tmasternak

authored and

ramonsmits

committed

maintenance mode test

tmasternak

authored and

ramonsmits

committed

startup mode test

tmasternak

authored and

ramonsmits

committed

customcheck tests using persister settings directly

tmasternak

authored and

ramonsmits

committed

bringing back the done condition in custom check tests

tmasternak

authored and

ramonsmits

committed

removing obsolete todos

tmasternak

authored and

ramonsmits

committed

no generic persistence settings registration in DI

tmasternak

authored and

ramonsmits

committed

cleanup

tmasternak

authored and

ramonsmits

committed

cleanup

tmasternak

authored and

ramonsmits

committed

tweaking approval tests for custom checks

tmasternak

authored and

ramonsmits

committed

removing todo

tmasternak

authored and

ramonsmits

committed

import failed messages command fixing using

tmasternak

authored and

ramonsmits

committed

maintenance settings moved to the ravendb specific settings class

tmasternak

authored and

ramonsmits

committed

maintenance settings moved to the ravendb specific settings class

tmasternak

authored and

ramonsmits

committed

Enabled test ServiceControl.UnitTests.API.APIApprovals::PlatformSampleSettings

ramonsmits

committed

⚜️ Appsettings cleanup, applied formatting. XML files seem to be using tab indentation so aligned all files. Removed all references to c:\ and use %TEMP%

ramonsmits

committed

⚜️ Strange editor config references

ramonsmits

committed

🐛 Envvar settings reader behavior aligned to all support underscore replacements for slash '/' and dot '.' in key names

ramonsmits

committed

🩹 Validate if connection string value exists

ramonsmits

committed

Removed C:\ usage

ramonsmits

committed

Fix commit b4944bbd2114cd0f14d6543141742f919cfe8656.

ramonsmits

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactored settings handling#3682

Refactored settings handling#3682
DavidBoike merged 33 commits intomasterfrom
settings

Commits on Sep 5, 2023

First revision with commented code in implementation regarding settings validation

Validating some settings values at persister creation and setting default values on settings type

PersisterSettings converted into marker interface to that at runtime the persister specific settings can serialized to JSON for diagnostics output in the REST API

Refactorings on SettingsReader

⚜️ Code readability

🔨 Settings readers now using `TypeDescriptor.GetConverter` as `Convert.ChangeType` can't convert to TimeSpan and now supports TryRead on on SettingsReader to deal with non-nulleable types

⚜️ Improved readability of free/total storage log entries

`PersistenceFactory.Create` now only takes a dependency on `Settings` which has its `PersisterSettings property change from Dictionary to IPersisterSettings. This allows for a persister specific im…

small tweaks

⚜️Code readability

🔨 Removed settings from app config by extending settings constructor with optional arguments for these and have the test runner pass explicit values for these removing the need to copy settings ru…

🩹 Fix test, specify required setting values

fixing maintenance mode startup

maintenance mode test

startup mode test

customcheck tests using persister settings directly

bringing back the done condition in custom check tests

removing obsolete todos

no generic persistence settings registration in DI

cleanup

cleanup

tweaking approval tests for custom checks

removing todo

import failed messages command fixing using

maintenance settings moved to the ravendb specific settings class

maintenance settings moved to the ravendb specific settings class

Enabled test ServiceControl.UnitTests.API.APIApprovals::PlatformSampleSettings

⚜️ Appsettings cleanup, applied formatting. XML files seem to be using tab indentation so aligned all files. Removed all references to c:\ and use %TEMP%

⚜️ Strange editor config references

🐛 Envvar settings reader behavior aligned to all support underscore replacements for slash '/' and dot '.' in key names

🩹 Validate if connection string value exists

Removed C:\ usage

Fix commit b4944bbd2114cd0f14d6543141742f919cfe8656.