Lifecycle refactoring and fixing of various IHost dispose issues
#3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
force-pushed
the
lifecycle-wrap-host-run
branch
from
4cbc6ac to
e4d2530
Compare
…I��Hosted services have indirect dependencies on IDocumentStore which previously was only initialized when the hosted service wrapper for persistence lifecycle its start method was invoked by the extension host. This is too late. This change ensures lifecycle is async initialized so that during DI resolution IDocumentStore can actually be resolved.
ramonsmits
force-pushed
the
lifecycle-wrap-host-run
branch
from
e4d2530 to
2c11601
Compare
DavidBoike
reviewed
Sep 14, 2023
…creation into RavenDbInstaller.Install so that is can also be disposed there
DavidBoike
approved these changes
Sep 18, 2023
…ialize the IDocumentStore
…rces that are disposed at the end of tests
ramonsmits
changed the title
IHost dispose issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosted services are dependent on the document store which needs to be initialized before the hosted services are created by the hosting extensions.
During refactoring it was noticed that the created host are not properly being disposed by both commands and tests. All created hosts should now be properly be disposed as the end of its usage.