Store message body attachments on FailedMessage documents #3719
Conversation
| var documentId = MessageBodyIdGenerator.MakeDocumentId(messageId); | ||
| using var session = documentStore.OpenAsyncSession(); | ||
|
|
||
| // BodyId could be a MessageID or a UniqueID, but if a UniqueID then it will be a DeterministicGuid of MessageID and endpoint name and be Guid-parseable |
There was a problem hiding this comment.
Why can it be a message ID or unique ID?
There was a problem hiding this comment.
Because in my redesign, we're always storing it using the unique ID, and the message metadata will say "look at messages/{uniqueId}/body for the body" so in theory, it should always be the unique ID. But previous versions stored the body only by message ID and while in theory, Pulse and Insight should pay attention to the message metadata that points to the uniqueID-based URL, it's impossible for me to say that assumption hasn't leaked into one of those apps. So just following what the API looks like, it's entirely reasonable some client somewhere could try to access by message ID.
There was a problem hiding this comment.
If we test SI + SP and they use the BodyUrl we could simplify this and only use Unique ID?
src/ServiceControl.Persistence.Tests.RavenDb/TestPersistenceImpl.cs
Outdated
Show resolved
Hide resolved
… an index lookup by MessageId and return that
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
DavidBoike
force-pushed
the
body-storage
branch
from
a21fe35 to
99a8e8b
Compare
No description provided.