Move MultiInstance tests to RavenDB 5 #3720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmasternak
previously requested changes
Oct 3, 2023
ramonsmits
approved these changes
Oct 3, 2023
Member
ramonsmits
left a comment
ramonsmits
left a comment
There was a problem hiding this comment.
Ok with this although it feels a bit complex
tmasternak
reviewed
Oct 3, 2023
...eControl.MultiInstance.AcceptanceTests/SagaAudit/When_sending_saga_audit_to_main_instance.cs
Outdated
Show resolved
Hide resolved
ramonsmits
reviewed
Oct 4, 2023
| using System.Threading.Tasks; | ||
| using NServiceBus.CustomChecks; | ||
|
|
||
| class SagaAuditDestinationCustomCheck : CustomCheck |
Member
There was a problem hiding this comment.
Do we want to add an obsolete tag to remove this in SC 6.0?
Member
Author
There was a problem hiding this comment.
We don't have ObsoleteEx in ServiceControl. Do you just mean a regular Obsolete? Do you think that would even get found / looked for?
I can definitely raise an issue in the repo and put it on the 6.0.0 milestone.
ramonsmits
reviewed
Oct 4, 2023
ramonsmits
reviewed
Oct 4, 2023
ramonsmits
reviewed
Oct 4, 2023
| return passResult; | ||
| } | ||
|
|
||
| var message = $"In the last 24 hours, the following endpoints have reported saga audit data to the ServiceControl Primary instance. Instead, saga audit data should be sent to the Audit Queue Name configured in the ServiceControl Audit Instance. Affected endpoints: " |
ramonsmits
approved these changes
Oct 4, 2023
Member
ramonsmits
left a comment
ramonsmits
left a comment
There was a problem hiding this comment.
LGTM, added a few code comment suggestions regarding resolving the audit queue
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.