Skip to content

Conversation

@ramonsmits
Copy link
Member

Remove confusion about ServerUrl by removing DatabaseMaintenanceUrl and documenting settings property

@ramonsmits ramonsmits self-assigned this Oct 3, 2023
@DavidBoike DavidBoike marked this pull request as draft October 3, 2023 15:38
@DavidBoike
Copy link
Member

Ramon and I decided we should check to see what the Audit instance is doing and potentially roll changes to that into this PR as well.

@ramonsmits
Copy link
Member Author

Analyzed audit instance. Audit instance only uses localhost for the server URL:

https://github.com/Particular/ServiceControl/blob/c4ac6aa6/src/ServiceControl.Audit.Persistence.RavenDb5/RavenDbPersistenceConfiguration.cs#L64

Going to apply the same for primary instance.

…tance follows same behavior as audit instance to only use localhost for embedded instance
@ramonsmits ramonsmits marked this pull request as ready for review October 4, 2023 14:51
@DavidBoike DavidBoike enabled auto-merge (squash) October 4, 2023 17:12
@DavidBoike DavidBoike merged commit c7a5c45 into master Oct 4, 2023
@DavidBoike DavidBoike deleted the serverurl branch October 4, 2023 18:33
@DavidBoike DavidBoike added this to the 5.0.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants