Skip to content

Disable docker images build and publishing #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmasternak merged 3 commits into from
Oct 13, 2023
Merged

Disable docker images build and publishing #3745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18f60ac
disable Docker image building
tmasternak Oct 13, 2023
829102d
removing docker build and publish from the release workflow
tmasternak Oct 13, 2023
a5cabae
Comment workflow lines instead
DavidBoike Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ jobs:
env:
AZURE_KEY_VAULT_CLIENT_SECRET: ${{ secrets.AZURE_KEY_VAULT_CLIENT_SECRET }}
run: dotnet build src/Setup --configuration Release
- name: Build Docker images
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
run: dotnet build src/ServiceControl.DockerImages --configuration Release
- name: List Docker images
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
shell: pwsh
run: docker images
# - name: Build Docker images
# if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
# run: dotnet build src/ServiceControl.DockerImages --configuration Release
# - name: List Docker images
# if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
# shell: pwsh
# run: docker images
- name: Publish assets
uses: actions/upload-artifact@v3.1.3
with:
Expand Down Expand Up @@ -146,20 +146,20 @@ jobs:
with:
octopus-deploy-api-key: ${{ secrets.OCTOPUS_DEPLOY_API_KEY }}
additional-metadata-paths: ServiceControlMetadata.json
- name: Login to Docker Hub
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
uses: docker/login-action@v3.0.0
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Push Docker images
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
shell: pwsh
run: |
Get-ChildItem -Path dockerfiles -Filter *.dockerfile | ForEach-Object {
$dockerImageName = $_.Name.SubString(0, $_.Name.Length - ".dockerfile".Length);
$dockerpushcmd = "docker push particular/" + $dockerImageName +":${{ env.MinVerVersion }}"
echo "Docker Push Command: $dockerpushcmd"
Invoke-Expression $dockerpushcmd.ToLower()
}
# - name: Login to Docker Hub
# if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
# uses: docker/login-action@v3.0.0
# with:
# username: ${{ secrets.DOCKERHUB_USERNAME }}
# password: ${{ secrets.DOCKERHUB_TOKEN }}
# - name: Push Docker images
# if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
# shell: pwsh
# run: |
# Get-ChildItem -Path dockerfiles -Filter *.dockerfile | ForEach-Object {
# $dockerImageName = $_.Name.SubString(0, $_.Name.Length - ".dockerfile".Length);
#
# $dockerpushcmd = "docker push particular/" + $dockerImageName +":${{ env.MinVerVersion }}"
# echo "Docker Push Command: $dockerpushcmd"
# Invoke-Expression $dockerpushcmd.ToLower()
# }
4 changes: 3 additions & 1 deletion src/ServiceControl.DockerImages/ServiceControl.DockerImages.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@

</ItemGroup>

<Target Name="CleanGeneratedDockerfiles" AfterTargets="Build">
<!-- NOTE: this should be re-enabled after ServiceControl can be run on Linux -->
<!--<Target Name="CleanGeneratedDockerfiles" AfterTargets="Build">-->
<Target Name="CleanGeneratedDockerfiles">
<ItemGroup>
<Dockerfiles Include="$(DockerfilesFolder)*.dockerfile" />
</ItemGroup>
Expand Down