Skip to content

Monitoring cannot process metrics for processed polymorphic messages #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramonsmits merged 1 commit into from
Oct 24, 2023
Merged

Monitoring cannot process metrics for processed polymorphic messages #3760

ramonsmits merged 1 commit into from
Oct 24, 2023

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Oct 18, 2023

@ramonsmits
Fix flooding the logs with "Error parsing message type:" for metrics …
34bd04b 
…from polymorphic messages (#3661)

* The received value is the value from NServiceBus.EnclosedMessageTypes which can contain multiple types

* Modifed tests to use polymorphic messages

* No longer affected, removing validation

* Moved parsing to contructor of `EndpointMessageType`
@ramonsmits ramonsmits added the Bug label Oct 18, 2023
@ramonsmits ramonsmits added this to the 4.32.3 milestone Oct 18, 2023
@ramonsmits ramonsmits requested a review from soujay October 18, 2023 15:40
@ramonsmits ramonsmits self-assigned this Oct 18, 2023
@ramonsmits ramonsmits merged commit d4d1ddb into release-4.32 Oct 24, 2023
@ramonsmits ramonsmits deleted the backport-3661-4.32 branch October 24, 2023 12:57
@ramonsmits ramonsmits changed the title Fix flooding the logs with "Error parsing message type:" for metrics from polymorphic messages Monitoring cannot process messages where EnclosedMessageTypes contains multiple values Oct 25, 2023
@ramonsmits ramonsmits changed the title Monitoring cannot process messages where EnclosedMessageTypes contains multiple values Monitoring cannot process metrics for processed polymorphic messages Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soujay soujay soujay approved these changes

Assignees

@ramonsmits ramonsmits

Labels

Bug

Projects

None yet

Milestone

4.32.3

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonsmits @soujay