Skip to content

Conversation

@bording
Copy link
Member

@bording bording commented Oct 20, 2023

Updates transport and persistence manifest management to improve the way the debug-time F5 experience is implemented.

Previously the projects used artifact copying to move transport and persistence bits around into subdirectories of each app. This is an inversion of normal project dependencies that could cause problems, such as making changes to persistence code and not having the correct code loaded for debugging unless the persistence library was specifically rebuilt before running the project.

In this reconfiguration, artifacts are not copied around in this way, but the transport and persistence loading infrastructure instead understands where those projects will exist on disk during the development process, and can load the assemblies directly from the artifacts of that transport/persistence project, without needing them to exist in a subdirectory of the app's own bin folder.

The loading infrastructure can still load the transport or persistence plugins from a subdirectory as well, which will be the new layout for a production build. This gets us closer to a paradigm that will be necessary for Docker deployments where the binaries for all transport and persistence options are present and config or environment variables are used to choose which plugin to load at runtime.

Copy link
Member

@DavidBoike DavidBoike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding some suggestions because at first glance that looks like something that could throw. Verified return-null behavior in both .NET and .NET Framework in different versions of LINQPad.

@DavidBoike DavidBoike marked this pull request as ready for review October 24, 2023 16:48
@DavidBoike DavidBoike merged commit 2b3e678 into master Oct 24, 2023
@DavidBoike DavidBoike deleted the dev-manifests-f5 branch October 24, 2023 17:02
@DavidBoike DavidBoike added this to the 5.0.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants