-
Notifications
You must be signed in to change notification settings - Fork 48
Improve development manifest discovery #3767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
approved these changes
Oct 23, 2023
ac54943 to
e964854
Compare
DavidBoike
approved these changes
Oct 24, 2023
Member
DavidBoike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding some suggestions because at first glance that looks like something that could throw. Verified return-null behavior in both .NET and .NET Framework in different versions of LINQPad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates transport and persistence manifest management to improve the way the debug-time F5 experience is implemented.
Previously the projects used artifact copying to move transport and persistence bits around into subdirectories of each app. This is an inversion of normal project dependencies that could cause problems, such as making changes to persistence code and not having the correct code loaded for debugging unless the persistence library was specifically rebuilt before running the project.
In this reconfiguration, artifacts are not copied around in this way, but the transport and persistence loading infrastructure instead understands where those projects will exist on disk during the development process, and can load the assemblies directly from the artifacts of that transport/persistence project, without needing them to exist in a subdirectory of the app's own bin folder.
The loading infrastructure can still load the transport or persistence plugins from a subdirectory as well, which will be the new layout for a production build. This gets us closer to a paradigm that will be necessary for Docker deployments where the binaries for all transport and persistence options are present and config or environment variables are used to choose which plugin to load at runtime.