-
Notifications
You must be signed in to change notification settings - Fork 48
Optimize binaries #3773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Optimize binaries #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
commented
Oct 24, 2023
src/ServiceControl.Audit.Persistence.RavenDb5/Indexes/MessagesViewIndex.cs
Outdated
Show resolved
Hide resolved
ramonsmits
reviewed
Oct 25, 2023
src/ServiceControl.Audit.Persistence.RavenDb5/Indexes/MessagesViewIndexWithFullTextSearch.cs
Outdated
Show resolved
Hide resolved
ramonsmits
reviewed
Oct 25, 2023
| <ItemGroup> | ||
| <ProjectReference Include="..\ServiceControl.Infrastructure\ServiceControl.Infrastructure.csproj" /> | ||
| <ProjectReference Include="..\ServiceControl.Persistence\ServiceControl.Persistence.csproj" /> | ||
| <!-- Private=false & ExcludeAssets=runtime prevent repeatedly including binary dependencies of ServiceControl.Persistence in each persister directory --> |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense as those assemblies are already there at runtime. I thought copying was only done for packages and executables but likely that is pre SDK behavior.
tmasternak
approved these changes
Oct 25, 2023
…ence abstractions in each transport/persister
…ncies excluded by each transport plugin
…ring in dependencies excluded by each persistence plugin
321275a to
bd002a5
Compare
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
9dd5fd4 to
4041367
Compare
bording
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does so by:
<ProjectReference Include="**.csproj" Private="false" ExcludeAssets="runtime" />)