Custom lifetime manager to prevent Windows Service start timeout - Generic IHostLifetime wrapper #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
requested review from
bording,
danielmarbach,
mauroservienti and
tmasternak
ramonsmits
changed the title
…ze()` as part of `IHostLifetime.WaitForStartAsync(..)` so that the application will not timeout in the (Windows) Service Control Manager and kill the process.
ramonsmits
force-pushed
the
custom-lifetime
branch
from
21468e7 to
1f9917e
Compare
tmasternak
reviewed
Jan 16, 2024
| hostBuilder.UseWindowsService(); | ||
| hostBuilder.ConfigureServices(s => | ||
| { | ||
| s.AddSingleton<WindowsServiceLifetime>(); |
Member
There was a problem hiding this comment.
do we need this, considering line 15?
Member
Author
There was a problem hiding this comment.
Yes, as that line only registers an interface implementation and not the implementation separately.
| using ServiceControl.Persistence; | ||
|
|
||
|
|
||
| sealed class PersisterInitializingLifetimeWrapper : IHostLifetime |
Member
There was a problem hiding this comment.
could we make this more generic i.e. independent of persisted? Could be called HostLifetimeWithInitializationPhase
Member
Author
There was a problem hiding this comment.
It could but then it should also have a constructor that allows for a more generic initialization but I don't think that is needed.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PersisterInitializingLifetimeWrapperthat is DI configured to use a specific console or windowsservice lifetime.