Remove audit queue validation checks #4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBZA
approved these changes
Mar 28, 2024
SzymonPobiega
approved these changes
Mar 28, 2024
danielmarbach
approved these changes
Mar 28, 2024
mauroservienti
approved these changes
Mar 28, 2024
mikeminutillo
added a commit
that referenced
this pull request
Apr 5, 2024
Merged
mikeminutillo
added a commit
that referenced
this pull request
Apr 8, 2024
* Diagnostic improvements and bulk insert time config setting (#4049) * Add exception logging to DomainEvents * Add NServiceBus reference * Add debug logging to EndpointInstanceMonitor * Add configurable bulk insert timeout --------- Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> * Remove audit queue validation checks (#4048) * Fix small validation bugs (#4046) * Allow propogation of propertychange events * Prevent event bubbling * Switch back to invalid file chars * Add notify propogation tests * Add file path sanitization tests --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net> * Fix test for primary instance convention default Original commit is here 84f61ec * RavenDb License refresh --------- Co-authored-by: Szymon Pobiega <szymon.pobiega@gmail.com> Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> Co-authored-by: John Simons <john.simons@particular.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new ServiceControl installation via ServiceControl Management, there are validation checks to ensure that two instances on the same machine do not use the same Audit queue or Audit Forwarding queue. This check made sense when there was only one audit instance per environment. Since the audit instance was split from the error instance, it is possible to run two audit instances in the same environment. It may make sense to run those against the same audit queue.
This PR removes those validation checks.