SagaAudit Timespan parsing fallback to "g" format in cases where "c" is not enough to stay compatible with previous versions #4199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
changed the title
danielmarbach
requested review from
DavidBoike,
NChaganlal,
bording and
mauroservienti
mauroservienti
approved these changes
May 29, 2024
NChaganlal
approved these changes
May 29, 2024
danielmarbach
added a commit
that referenced
this pull request
May 29, 2024
…is not enough to stay compatible with previous versions (#4199) * CustomTimeSpanConverterTests * Align the lower range to what I have contributed to .NET runtime * More test cases and grouping * Fallback to parsing with "g" format --------- Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com> (cherry picked from commit 99fe799)
danielmarbach
added a commit
that referenced
this pull request
May 29, 2024
…is not enough to stay compatible with previous versions (#4199) (#4203) * CustomTimeSpanConverterTests * Align the lower range to what I have contributed to .NET runtime * More test cases and grouping * Fallback to parsing with "g" format --------- Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com> (cherry picked from commit 99fe799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4202
Follow through on #4142 since we covered more edge cases that weren't covered with the "c" format restrictions being lifted I have added a fallback to parsing with the "g" format should the "c" format parsing return false.
This should make the code compliant hopefully all cases that came from the previous plugin versions using custom timespan formatting
This needs to be back ported to 5.2