Skip to content

Conversation

@DavidBoike
Copy link
Member

@DavidBoike DavidBoike commented Jun 18, 2024

Fills out the annotations at the index (top-most) level. Since Docker Hub doesn't appear to support displaying any of these yet, this just a first "good-enough" pass.

The resulting annotations from docker buildx imagetools inspect are:

  "annotations": {
    "org.opencontainers.image.authors": "Particular Software",
    "org.opencontainers.image.base.name": "mcr.microsoft.com/dotnet/aspnet:8.0",
    "org.opencontainers.image.created": "2024-06-19T17:40:18Z",
    "org.opencontainers.image.description": "ServiceControl primary instance",
    "org.opencontainers.image.documentation": "https://docs.particular.net/servicecontrol/",
    "org.opencontainers.image.revision": "7e2e444ac98ed35bfc45cb14defc8277211f4592",
    "org.opencontainers.image.source": "https://github.com/Particular/ServiceControl/tree/7e2e444ac98ed35bfc45cb14defc8277211f4592",
    "org.opencontainers.image.title": "servicecontrol",
    "org.opencontainers.image.url": "https://hub.docker.com/r/particular/servicecontrol",
    "org.opencontainers.image.vendor": "Particular Software",
    "org.opencontainers.image.version": "5.2.1-alpha.0.51"
  }

@DavidBoike DavidBoike marked this pull request as ready for review June 19, 2024 17:45
@DavidBoike DavidBoike requested review from boblangley and bording June 19, 2024 17:45
@DavidBoike DavidBoike self-assigned this Jun 19, 2024
@bording bording changed the title Adding container image annotations Add container image annotations Jun 19, 2024
Co-authored-by: Brandon Ording <bording@gmail.com>
@DavidBoike DavidBoike requested a review from bording June 19, 2024 19:10
@DavidBoike DavidBoike requested a review from bording June 20, 2024 13:30
@DavidBoike DavidBoike merged commit 4b26c03 into master Jun 20, 2024
@DavidBoike DavidBoike deleted the annotations branch June 20, 2024 20:22
@DavidBoike DavidBoike mentioned this pull request Jun 26, 2024
bording added a commit that referenced this pull request Jun 27, 2024
* Add one annotation

* more annotations, at manifest+index levels

* no equals

* Oops, bash not pwsh

* so many options

* All in index

* Fill out annotations, focus only on index for now

* Update .github/workflows/release.yml

Co-authored-by: Brandon Ording <bording@gmail.com>

* primary -> error

---------

Co-authored-by: Brandon Ording <bording@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants