Add InstanceName setting to control the Service/Endpoint/Queue name #4313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
HostArgumentsandCommandRunnerfor all 3 instances so that they work in the same way.CommandRunnersupported the idea of running multiple commands, but there was no way to use it. Also, the commands themselves were written in a way that assumed a single command would be executed per process. The ability to run multiple commands has been removed.InstanceNameis now the consistent setting to use across all 3 instances to control the name of the endpoint/queue used by the instance.InternalQueueName) will still be used if set, but the new setting will take precedence if they are both set.EndpointName) did not work properly (it was never passed toEndpointConfigurationso instance would never consume from that queue. The broken setting has been removed and entirely replaced withInstanceName.serviceNamecommand-line parameter has been removed. Instances will now rely on theInstanceNameconfiguration setting instead.userNamecommand-line parameter was not actually being used for anything, so it has also been removed.InstanceNameto the app.config file when installing or upgrading an instance.InternalQueueNameset, the installer will migrate the value toInstanceNameand remove theInternalQueueNamesetting.