Skip to content

Conversation

@bording
Copy link
Member

@bording bording commented Jul 16, 2024

This PR makes the following changes:

  • Aligns HostArguments and CommandRunner for all 3 instances so that they work in the same way.
  • CommandRunner supported the idea of running multiple commands, but there was no way to use it. Also, the commands themselves were written in a way that assumed a single command would be executed per process. The ability to run multiple commands has been removed.
  • InstanceName is now the consistent setting to use across all 3 instances to control the name of the endpoint/queue used by the instance.
    • The old setting for error and audit instances (InternalQueueName) will still be used if set, but the new setting will take precedence if they are both set.
    • The old setting for monitoring (EndpointName) did not work properly (it was never passed to EndpointConfiguration so instance would never consume from that queue. The broken setting has been removed and entirely replaced with InstanceName.
  • The serviceName command-line parameter has been removed. Instances will now rely on the InstanceName configuration setting instead.
  • The userName command-line parameter was not actually being used for anything, so it has also been removed.
  • The installer engine has been updated to handle properly writing InstanceName to the app.config file when installing or upgrading an instance.
    • When upgrading an instance that had InternalQueueName set, the installer will migrate the value to InstanceName and remove the InternalQueueName setting.

@bording bording requested review from DavidBoike and boblangley July 16, 2024 20:48
@bording bording changed the title Service name Improve how to control the Service/Endpoint/Queue name Jul 16, 2024
@bording bording marked this pull request as draft July 16, 2024 22:16
@bording bording marked this pull request as ready for review July 19, 2024 21:11
@bording bording changed the title Improve how to control the Service/Endpoint/Queue name Add InstanceName setting to control the Service/Endpoint/Queue name Jul 19, 2024
@boblangley boblangley merged commit fc2b2d9 into master Jul 19, 2024
@boblangley boblangley deleted the service-name branch July 19, 2024 22:30
@bording bording added this to the 5.5.0 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants