Disable report download if using a broker but there is no broker data for last 30 days #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… audit or monitoring data exists
johnsimons
requested changes
Jul 18, 2024
src/Particular.LicensingComponent.UnitTests/Infrastructure/ThroughputCollectorTestFixture.cs
Show resolved
Hide resolved
johnsimons
reviewed
Jul 19, 2024
abparticular
force-pushed
the
disable-report-generation-if-broker-issues
branch
from
df93814 to
23e08b5
Compare
…it not matching how ServicePulse refers to brokers
johnsimons
reviewed
Jul 19, 2024
jpalac
changed the title
jpalac
changed the title
johnsimons
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the report download button on the Usage page is enabled as long as there is 1 day of data in the last 30 days.
This could produce incomplete reports if a broker transport is used but not configured correctly, and the data is only coming from a subset of endpoints that have Audit and/or Monitoring configured.
This change ensures that the report download button is not enabled if a broker transport is being used, but there's no data from the broker.