Skip to content

dont query star for SQL table check #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavidBoike merged 1 commit into from
Jul 22, 2024
Merged

dont query star for SQL table check #4317

DavidBoike merged 1 commit into from
Jul 22, 2024

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jul 22, 2024

also use raw string to make the query string alloc smaller

@SimonCropp
Copy link
Contributor Author

SimonCropp commented Jul 22, 2024

looks like the failure is unrelated to my change?

@DavidBoike DavidBoike changed the base branch from master to sql-queue-length July 22, 2024 21:25
@DavidBoike DavidBoike merged commit e874f76 into Particular:sql-queue-length Jul 22, 2024
@DavidBoike DavidBoike mentioned this pull request Jul 22, 2024
Merged
bording pushed a commit that referenced this pull request Jul 22, 2024
@DavidBoike @SimonCropp
Optimizations to SQL queue length provider (#4327)
3caca15 
* dont query star (#4317)

* avoid array alloc in sql UpdateChunk (#4318)

---------

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
@SimonCropp SimonCropp deleted the dont-query-star branch July 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonCropp @DavidBoike