Skip to content

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jul 22, 2024

  • cache sql QueueLengthQuery on table to avoid calculating it every time in the fast path
  • use _fullTableName in calculation of query and re-use it in quals, hashcode, and tostring
  • remove SqlNameHelper.Unquote since not used
  • enabled nullable checks for SqlNameHelper and SqlTable

@DavidBoike
Copy link
Member

This looks like a good change but we decided we didn't have time to fully kick the tires and still release 5.5 today. Should be considered for the next release.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 23, 2024
@SimonCropp
Copy link
Contributor Author

@DavidBoike can u re open and disable that stale PR bot. clearly the Particular process moves slower than that bot closes PRs

@DavidBoike DavidBoike changed the base branch from master to cache-sqltable-query August 23, 2024 20:31
@DavidBoike DavidBoike merged commit d319520 into Particular:cache-sqltable-query Aug 23, 2024
DavidBoike added a commit that referenced this pull request Aug 23, 2024
* cache sqltable query

* Update SqlNameHelper.cs

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
@DavidBoike
Copy link
Member

Your comment alone would have resulted in the stale label being removed within 24 hours, but thanks for the reminder, I looked at this and I'm going to get it shipped in 5.7.0 next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants