Fix endpoint name display and grouping for Usage (#4545) #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update endpoint type display * Update src/Particular.LicensingComponent/ThroughputCollector.cs Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> * fix logic after merge of suggestion * Logging not displaying queue name * Refactor same logic from summary and report into one function * Modify existing tests to ensure we are testing for the right throughput being returned --------- Co-authored-by: WilliamBZA <WilliamBZA@users.noreply.github.com> Co-authored-by: John Simons <john.simons@particular.net>
johnsimons
approved these changes
Oct 22, 2024
jpalac
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4545
update endpoint type display
Update src/Particular.LicensingComponent/ThroughputCollector.cs
fix logic after merge of suggestion
Logging not displaying queue name
Refactor same logic from summary and report into one function
Modify existing tests to ensure we are testing for the right throughput being returned