refactor DeletedMessageGroups view data handling into a store #2692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilBastian
commented
Oct 31, 2025
# Conflicts: # src/Frontend/src/stores/MessageStore.ts
johnsimons
reviewed
Nov 19, 2025
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/failedmessages/messageGroupClient.ts
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
johnsimons
reviewed
Nov 19, 2025
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
Base automatically changed from
message_store_initialisation
to
monitoring_store
November 24, 2025 04:16
johnsimons
approved these changes
Nov 26, 2025
Co-authored-by: Phil Bastian <phil.bastian@particular.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1905, extending #2675 to remove direct SC calls from views