Duplicating communicator in MPI backend#35
Merged
amartinhuertas merged 2 commits intogridap_distributedfrom Oct 20, 2021
Merged
Duplicating communicator in MPI backend#35amartinhuertas merged 2 commits intogridap_distributedfrom
amartinhuertas merged 2 commits intogridap_distributedfrom
Conversation
Open
30 tasks
Collaborator
Author
|
Fixes issue #33 |
amartinhuertas
approved these changes
Oct 20, 2021
amartinhuertas
requested changes
Oct 20, 2021
Collaborator
amartinhuertas
left a comment
amartinhuertas
left a comment
There was a problem hiding this comment.
I now noticed that there are failing tests. The code looks good.
Codecov Report
@@ Coverage Diff @@
## gridap_distributed #35 +/- ##
======================================================
- Coverage 92.17% 92.12% -0.05%
======================================================
Files 8 8
Lines 2057 2058 +1
======================================================
Hits 1896 1896
- Misses 161 162 +1
Continue to review full report at Codecov.
|
Collaborator
Author
|
Now the tests are working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.