Migration: `com.passwordmanager` to `com.jeeldobariya.passcodes` by JeelDobariya38 · Pull Request #17 · PasscodesApp/Passcodes

JeelDobariya38 · 2025-07-28T12:46:18Z

Important

Attention! Attention! Major architecture changes!!

Changes Made

Migrated successfully from com.passwordmanager to com.jeeldobariya.passcodes.
Update Gradle 7.6 -> 8.14.3.
Migrate Gradle: Groovy (old) -> Kotlin DSL.
Compile Android App With SDK 36 and Move Target SDK from 33 -> 34.
Migrate the code from java to kotlin. [I have use Gemini 2.5 extensively just to migrate it faster I am still unfamiliar with code base and make sense of it. once i complete make sense of it will mark this pr as not drafted mean read to merge @kudanilll]
Migrate From SQLiteOpenHelper to Room Library.
Add Kotlin Flow library.
Add test for Room Database
Update changelogs.md and other documentations.
Change the project name from Password Manager to Passcodes where possible. [meaning, url are still not updated]
successfully closes Migration from com.passwordmanager to com.jeeldobariya.passcodes #14 and resolves ⁉️Doubt: Common Package Name⁉️ #12

TODO: yet left changes

Fix issue with app database call on main thread.
Automated test for instrumental app.
Other documentation changes.
Review the changes thoroughly.
Understand the codebase myself, if that counts 😂 (as i have use gemini)

…a.passcodes`" (#16) This reverts commit 08ca621, reversing changes made to 6838398.

waring: changes are not yet tested

compileSdk = 36 (android 13) targetSdk = 34 (android 14)

warn: commit consist of code which is not test, this commit alone itself is irreversible.

Use Gemini 2.5 Flash

JeelDobariya38 · 2025-07-28T16:34:22Z

@kudanilll please, through review the code and point any mistakes.. even if seems small as this is a major changes in project...

fix: the bug of database operation on main thread bug was introduce in 1fbcc9b This commit is not stand alone all previous commit are part of it. after bug are part of it. be very careful revert any of this commit as standalone chore(depsfix): fix a issue in build.gradle refactor: ViewPassword.kt to use coroutines refactor: UpdatePassword.kt to use coroutines refactor: SavePassword.kt to use coroutines refactor: LoadPassword.kt to use coroutines refactor: update the controller to use suspend function the commit is not complete as a whole feat: make every db operation a suspend function and use flows the commit is not complete as a whole chore(deps): add dependency for coroutines chore(deps): improve the build.gradle and make morder

JeelDobariya38 · 2025-07-29T07:53:22Z

Most code changes have been done!!. I am still make sense of codebase and also of test. (As this migration was mostly assisted by gemini. And also I am new to kotlin ecosystem)

From here, I don't think there will major changes. (In code, In this PR).
I have test the app on Android 15.

@kudanilll You also check the codebase!! And it better to review code in this branch as whole rather then this pr itself.

GitHub URL & README are still left.

JeelDobariya38 · 2025-07-29T13:45:43Z

@kudanilll 🥳🥳 Finally, migration is completed. Now, I will go through entire kotlin codebase and try make sense of it...

JeelDobariya38

I have thoroughly review the code and understand it and want to point out something to you @kudanilll that stick out to me while review the code...

Also, As I understand code, I am marking pr as ready to merge.... meaning undrafted.... and If everything is fine, Don't wait for me danil just proceed merge it....

Please provide your valuable feedback!! Thanks for your time...

JeelDobariya38 · 2025-07-31T06:08:40Z

app/src/main/kotlin/com/jeeldobariya/passcodes/ui/UpdatePasswordActivity.kt

+        binding = ActivityUpdatePasswordBinding.inflate(layoutInflater)
+        setContentView(binding.root)
+
+        val intent = intent


I don't know, why gemini just did this, he/we initialized intent and then use it direct;y in next line... Do you @kudanilll, know any specific reason why this might be done?

Or is it a good practice in android community to first take the indent in variable and then do, stuff with it?

Similar changes are also found in ‎app/src/main/kotlin/com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt

JeelDobariya38 · 2025-07-31T06:14:09Z

app/src/main/kotlin/com/jeeldobariya/passcodes/ui/adapter/PasswordAdapter.kt

+class PasswordAdapter(
+    private val context: Context,
+    private var passwordList: List<Password> // Use mutable list if you need to update it
+) : BaseAdapter() {


I am as Android Beginner, not know of this Adaptor stuff, But still Accept this changes!! I will later, try to learn it...

I can sort of make sense of it as fragment.. but, I am not sure!! And still learn....

I hope @kudanilll you will take care of this code, if any issue occur until I fully learn this stuff!!

JeelDobariya38 · 2025-07-31T07:00:34Z

app/src/main/kotlin/com/jeeldobariya/passcodes/ui/LoadPasswordActivity.kt

+    private fun addOnClickListenerOnButton() {
+        binding.passwordList.setOnItemClickListener { _, _, position, _ ->


Important
POTENTIAL BUG!!
But, It's not yet encountered by me in any debug build that, I made or share with fellow friend/tester, @jainil63.

This code to me seems to be buggy, I don't why? and I am not sure is it really?

I guess, It because, I see three thing that i like to point out...

passwordAdapter is a lateinit var, Which mean it value can be change later, and could be potential null at first. until we initialize it, in this case, this happen in collectPasswordList() when password are found.. or not. in both case this is initialized..

We are in addOnClickListenerOnButton() function, where we just add a event listener, Without do any prior null checks. Note that, In onCreate(). addOnClickListenerOnButton() is called before collectPasswordList().

Also, the initialization happen in specifically collect() of Flow. Which mean it could change over time. and passwordAdapter could be reinitialized, and there in that new instance there be no onclicklistener on it, As we call the method only once in onCreate().

Anyways, Whatever the thing is, we will discuss it and probably, make work around it. But not in this PR [considering, there are already very many major change in this PR and it already review by danill and me, for multiple times, cost time & effort] Further changes on this, will be made in a new PR or under explicitly github issue (for bug specific)...

Please Provide Further Information @kudanilll.

Suggested change

private fun addOnClickListenerOnButton() {

binding.passwordList.setOnItemClickListener { _, _, position, _ ->

/*

TODO:

- A Null check & Throw explicit error for null values.

- Call this function every time on reinitialization of passwordAdapter.

- Make this Function idempotent.

*/

private fun addOnClickListenerOnButton() {

binding.passwordList.setOnItemClickListener { _, _, position, _ ->

JeelDobariya38 · 2025-07-31T07:05:02Z

app/src/main/kotlin/com/jeeldobariya/passcodes/utils/Permissions.kt

Changes in this file are also unfamiliar to me...
I am still learning permissions as android beginner...

But accept this changes as this is not my code and also, app don't use this stuff!!

JeelDobariya38 and others added 3 commits July 28, 2025 18:12

chore(deps): update gradle 8.14.3

abf5de1

Merge branch 'main' into feat-package-migration-jeel-dev

99aba7f

Reapply "Feat: Migrate from com.passwordmanager to `com.jeeldobariy…

c12b4e9

…a.passcodes`" (#16) This reverts commit 08ca621, reversing changes made to 6838398.

JeelDobariya38 self-assigned this Jul 28, 2025

JeelDobariya38 added enhancement New feature or request refactor refactor the code labels Jul 28, 2025

JeelDobariya38 marked this pull request as draft July 28, 2025 12:48

JeelDobariya38 added 8 commits July 28, 2025 19:00

chore(deps): update to Grade DSL and update dependency to latest

d43ca81

waring: changes are not yet tested

chore(deps): compile app against api 36.

ada91b0

compileSdk = 36 (android 13) targetSdk = 34 (android 14)

docs: update with latest info

c3b4e24

chore: make sure to print all warnings in Gradle

4583788

refactor: permissions util class

cf9767b

feat: migrate to room

b2cd553

warn: commit consist of code which is not test, this commit alone itself is irreversible.

refactor: made a binding class member

dae2bc7

refactor: migrate the rest of codebase

1fbcc9b

Use Gemini 2.5 Flash

JeelDobariya38 requested a review from kudanilll July 28, 2025 16:32

JeelDobariya38 force-pushed the feat-package-migration-jeel-dev branch from b9d521d to d5617ef Compare July 29, 2025 06:13

test: add android test for room database

f5c7f7f

JeelDobariya38 added the tests change tests label Jul 29, 2025

JeelDobariya38 added 2 commits July 29, 2025 12:47

refactor: add a way to generate schema

a791f12

docs: update changelog.md

fa5aea0

kudanilll approved these changes Jul 29, 2025

View reviewed changes

JeelDobariya38 added 5 commits July 29, 2025 15:58

docs: Update security_guide.md

0bcd0df

docs: Update release-workflow.md

6a051af

docs: Update release-workflow.md

c40847e

docs: Update installing.md and made more casual readable and fun to read

306d6ad

docs: update installing.md

14f0323

JeelDobariya38 and others added 5 commits July 29, 2025 17:16

docs: update database-design-guide.md

2200230

docs: update database-design-guide.md with latest schema changes

3e54c67

docs: update building.md

b8471ce

chore: deprecated the installondevice.bat.

dacc3b4

refactor: project to have passcodes as name instead of password manager

5553e7e

GitHub URL & README are still left.

JeelDobariya38 force-pushed the feat-package-migration-jeel-dev branch from f950ed5 to 5553e7e Compare July 29, 2025 13:06

docs: update README.md add new optimistic feature

fc09838

JeelDobariya38 requested a review from kudanilll July 29, 2025 13:43

kudanilll approved these changes Jul 29, 2025

View reviewed changes

JeelDobariya38 added the documentation Improvements or additions to documentation label Jul 30, 2025

JeelDobariya38 commented Jul 31, 2025

View reviewed changes

JeelDobariya38 marked this pull request as ready for review July 31, 2025 07:49

JeelDobariya38 merged commit 6f80203 into main Aug 1, 2025

JeelDobariya38 deleted the feat-package-migration-jeel-dev branch August 1, 2025 12:25

JeelDobariya38 changed the title ~~Migration from com.passwordmanager to com.jeeldobariya.passcodes~~ Migration: com.passwordmanager to com.jeeldobariya.passcodes Aug 15, 2025

JeelDobariya38 added the highlights highly impactful changes label Aug 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration: `com.passwordmanager` to `com.jeeldobariya.passcodes`#17

Migration: `com.passwordmanager` to `com.jeeldobariya.passcodes`#17
JeelDobariya38 merged 26 commits intomainfrom
feat-package-migration-jeel-dev

JeelDobariya38 commented Jul 28, 2025 •

edited

Loading

Uh oh!

JeelDobariya38 commented Jul 28, 2025

Uh oh!

JeelDobariya38 commented Jul 29, 2025

Uh oh!

JeelDobariya38 commented Jul 29, 2025 •

edited

Loading

Uh oh!

JeelDobariya38 left a comment

Uh oh!

JeelDobariya38 Jul 31, 2025

Uh oh!

JeelDobariya38 Jul 31, 2025

Uh oh!

JeelDobariya38 Jul 31, 2025

Uh oh!

JeelDobariya38 Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		private fun addOnClickListenerOnButton() {
		binding.passwordList.setOnItemClickListener { _, _, position, _ ->

Conversation

JeelDobariya38 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

TODO: yet left changes

Uh oh!

JeelDobariya38 commented Jul 28, 2025

Uh oh!

JeelDobariya38 commented Jul 29, 2025

Uh oh!

JeelDobariya38 commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JeelDobariya38 left a comment

Choose a reason for hiding this comment

Uh oh!

JeelDobariya38 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

JeelDobariya38 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

JeelDobariya38 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

JeelDobariya38 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JeelDobariya38 commented Jul 28, 2025 •

edited

Loading

JeelDobariya38 commented Jul 29, 2025 •

edited

Loading