Merged
Conversation
JeelDobariya38
requested review from
hexCode63,
jainil63,
kudanilll and
razorblade23
JeelDobariya38
added
enhancement
…c/main/kotlin/com/jeeldobariya/passcodes/ui/UpdatePasswordViewModel.kt
JeelDobariya38
force-pushed
the
jeel-dev
branch
from
6249d7c to
ca196cc
Compare
kudanilll
requested changes
Nov 10, 2025
app/src/main/kotlin/com/jeeldobariya/passcodes/ui/UpdatePasswordAction.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/jeeldobariya/passcodes/ui/UpdatePasswordState.kt
Show resolved
Hide resolved
Member
Author
|
Your requested changes are all correct & justify but they will not be coordinate in this pr... This changes will be in future next few pr under #42 migration... Other then this, the on shot effect you have mention about. is good and i am take note of it when i start Jetpack Compose development i will do that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is not a stand alone migration... There will be further follow up PR (clean architecture) that will make code better....
#42
Changes Made