Conversation
…a to app/src/main/java/com/passwordmanager/ui/LoadPasswordActivity.java
kudanilll
requested changes
Aug 11, 2024
Member
kudanilll
left a comment
There was a problem hiding this comment.
- For Activity files, store them in the
packages/ui/herefolder so that the folder is more structured. - I recommend using
ViewBindingso that the code looks cleaner and easier to maintain and you don't need to create an init variable function. - For the toast message don't write it directly in hard code, use
getStringandstrings.xml.
Member
Author
Implement all of this. |
Member
Author
|
implemented all the changes which we requested and also add the listview using chatgpt. @kudanilll |
ghost
approved these changes
Aug 13, 2024
kudanilll
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Made