Skip to content

Feat: Create a Basic Prototype App#5

Merged
kudanilll merged 28 commits intomainfrom
jeel-dev-layout
Aug 13, 2024
Merged

Feat: Create a Basic Prototype App#5
kudanilll merged 28 commits intomainfrom
jeel-dev-layout

Conversation

@JeelDobariya38
Copy link
Member

@JeelDobariya38 JeelDobariya38 commented Aug 11, 2024

Change Made

  • create a basic functional app.
  • refactor the existing permission code.
  • extended the ui.

@JeelDobariya38 JeelDobariya38 requested review from a user and kudanilll August 11, 2024 15:56
@JeelDobariya38 JeelDobariya38 added the enhancement New feature or request label Aug 11, 2024
…a to app/src/main/java/com/passwordmanager/ui/LoadPasswordActivity.java
Copy link
Member

@kudanilll kudanilll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For Activity files, store them in the packages/ui/here folder so that the folder is more structured.
  • I recommend using ViewBinding so that the code looks cleaner and easier to maintain and you don't need to create an init variable function.
  • For the toast message don't write it directly in hard code, use getString and strings.xml.

@JeelDobariya38
Copy link
Member Author

  • For Activity files, store them in the packages/ui/here folder so that the folder is more structured.
  • I recommend using ViewBinding so that the code looks cleaner and easier to maintain and you don't need to create an init variable function.
  • For the toast message don't write it directly in hard code, use getString and strings.xml.

Implement all of this.
Is there anything else, yet left. Other then, the permission issue in lower Android version?

@JeelDobariya38 JeelDobariya38 requested review from kudanilll and removed request for kudanilll August 12, 2024 06:21
@JeelDobariya38
Copy link
Member Author

implemented all the changes which we requested and also add the listview using chatgpt. @kudanilll

@JeelDobariya38 JeelDobariya38 assigned ghost Aug 12, 2024
@kudanilll kudanilll merged commit 6022f0b into main Aug 13, 2024
@JeelDobariya38 JeelDobariya38 deleted the jeel-dev-layout branch August 18, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants