Refactor: Shared-Preference -> DataStore-Preference#52
Conversation
This reverts commit e4fd22c.
|
Is it okay to mention security vulnerability in pr description or changelog, or anywhere publicly... once the vulnerability is fixed. I think the answer would probably be 'no', but then how to inform the other team members that this particular pr or commit fix it.. or even how to tell user that update has released that fixs vulnerability so update to latest version... If it was backend the answer would easy because you can create new deployment and then mention vulnerability... but i don't know what to do in android's case Can security managers (@razorblade23 & @kudanilll) please help me with this.. |
app/src/main/kotlin/com/jeeldobariya/passcodes/utils/AppSettings.kt
Outdated
Show resolved
Hide resolved
|
I have try to find a good fit solution to this data store migration thing... but sadly i didn't end up with even a single one on internet... So, I have try make my own, based on some assumption... I haven't test it.. but you can find the solution that i propose in Can please check it for correctness.... |
this solution will kind of be my last try, if it work then that complete fine... otherwise, if it doesn't work we leave this for now... mean in passcodes app the users will need restore/reconfigure there settings again after update app (if that update involve change in app settings.. which possible, mostly updates will...) I will in future do something about it probably when passcode app is more mature and has other important features.... but currently the app will have something like this.. |
|
@yogeshpaliyal can please check the file and tell what you think... also would like if you can review the code.. also app/src/main/kotlin/com/jeeldobariya/passcodes/flags/FeatureFlagsSettings.kt#L24-95 |
Changes Made
💥 Breaking Changes 💥
DataStore, all previous app settings of user will be deleted & lost permanently. In this case, user will need to reconfigure the settings.Notes
This is attempt to fix a security vulnerability report by dependabot. related to proto buffers.