Conversation
…ager.git into jeel-dev
Member
Author
|
Note With successfull merge of this pull request along with #7 & #8 it will count as the app is prepared for the initial release. @kudanilll @HamadaNative is that ok? |
kudanilll
requested changes
Aug 25, 2024
Member
kudanilll
left a comment
There was a problem hiding this comment.
CHANGE THIS:
AboutUsActivity.java
its better to create a class called ConstantVar or use strings.xml to store link information, or you can store your links in build.gradle
kudanilll
approved these changes
Aug 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
It is intended to be only merged after the #7 as the code in this pull depends on that pull docs/security_guide.md file. So, it request to merge first that pull and then this.
TL;DR:
Changes Made
Important Changes In Build.gradle
Fixes Viewbinding Compatibility with Code Assist
This pull request successful fixes the viewbinding compatibility issue that arise in codeassist.
Icon Based Changes
This pull request add the icon in the app. Which is original create by @HamadaNative but added by me.
The icon is added after a through research on google. So, that similar concept/icon doesn't exist.
Conclusion
Reviewers, Please review the code & Merge it only after #7. And also if possible, Merge it after #8.