Skip to content

✨Preparing For First Initial Release ✨#9

Merged
kudanilll merged 15 commits intomainfrom
jeel-dev
Aug 25, 2024
Merged

✨Preparing For First Initial Release ✨#9
kudanilll merged 15 commits intomainfrom
jeel-dev

Conversation

@JeelDobariya38
Copy link
Member

@JeelDobariya38 JeelDobariya38 commented Aug 21, 2024

Important

It is intended to be only merged after the #7 as the code in this pull depends on that pull docs/security_guide.md file. So, it request to merge first that pull and then this.

TL;DR:

  • Prepared app for its first release by changing changelog, adding icon & enhancing a about us activity.
  • Also make some changes in build.gradle for better compatibility with all dev environment possible user by contributors.

Changes Made

  • Enhance a about screen and given info about developers and app development.
  • Given a warning to users (In About Us) about the application development & safety of passwords.
  • Update the changelog.
  • Add icon to app. (Which was created by @HamadaNative)

Important Changes In Build.gradle

  • change the code from buildFeature to Viewbinding. Coz, buildFeature is not compatible with gradle version we are using. (buildFeature on work with a specific dev environment while, Viewbinding works on both environment in desktop and also in mobile, Codeassist)

Fixes Viewbinding Compatibility with Code Assist

This pull request successful fixes the viewbinding compatibility issue that arise in codeassist.

Icon Based Changes

This pull request add the icon in the app. Which is original create by @HamadaNative but added by me.

The icon is added after a through research on google. So, that similar concept/icon doesn't exist.

Conclusion

Reviewers, Please review the code & Merge it only after #7. And also if possible, Merge it after #8.

@JeelDobariya38 JeelDobariya38 requested review from a user and kudanilll August 21, 2024 16:59
@JeelDobariya38 JeelDobariya38 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 21, 2024
@JeelDobariya38 JeelDobariya38 marked this pull request as ready for review August 21, 2024 17:30
@JeelDobariya38
Copy link
Member Author

Note

With successfull merge of this pull request along with #7 & #8 it will count as the app is prepared for the initial release.

@kudanilll @HamadaNative is that ok?

@JeelDobariya38 JeelDobariya38 removed the request for review from a user August 22, 2024 13:13
Copy link
Member

@kudanilll kudanilll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGE THIS:

AboutUsActivity.java
its better to create a class called ConstantVar or use strings.xml to store link information, or you can store your links in build.gradle

@kudanilll kudanilll merged commit 4dc2230 into main Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants