-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Implement AsyncEventLoopExecutor to lay foundation #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2b0a755 to
2eca931
Compare
|
Did this start as copy-pasta from a NIO implementation and then get pruned down to rip out unavailable dependencies? |
@CrownedPhoenix No, this started out as a new implementation. It actually started out really simple, just had the actor serial guard. But grew rather complex with all the different edge cases required for unit test parity. At some point, I wouldn't mind revisiting it and trying to split apart some of the responsibilities. It is admittedly pretty hard to follow right now. |
…ng AsyncEventLoop.
2eca931 to
a0368a0
Compare
Summary
Implement AsyncEventLoopExecutor that forms the basis of operations for NIOAsyncRuntime
Details
Usage Examples
Testing Performed
Tests coverage provided in tests ported from NIOPosix: #6.
The changes have also been tested in real-world application by running
GraphManagerandQuantumProjectManagerin the browser to migrate database schemas, connect with our server, and pull data from a real user account.PR Dependencies
#3
Overview of all changes
All planned changes can be viewed together in #2