This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Impl PlayerChangedDimensionEvent, PlayerRespawnEvent and PlayerLoggedOutEvent #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo60228
approved these changes
Jul 17, 2020
Contributor
leo60228
left a comment
leo60228
left a comment
There was a problem hiding this comment.
Apart from that bikeshedding, this PR seems fine.
...-events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinCraftingResultSlot.java
Show resolved
Hide resolved
| target = "net/minecraft/item/ItemStack.onCraft(Lnet/minecraft/world/World;Lnet/minecraft/entity/player/PlayerEntity;I)V" | ||
| ) | ||
| ) | ||
| private void onCrafted_stack_onCraft(ItemStack stack, CallbackInfo ci) { |
Contributor
There was a problem hiding this comment.
This method name is a bit strange. Maybe onStackCrafted?
| @Inject(method = "onCrafted(Lnet/minecraft/item/ItemStack;)V", | ||
| at = @At("RETURN") | ||
| ) | ||
| private void onCrafted_return(ItemStack stack, CallbackInfo ci) { |
Contributor
There was a problem hiding this comment.
See above, maybe onCraftingFinished?
patchwork-events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinItemEntity.java
Show resolved
Hide resolved
| target = "net/minecraft/item/ItemStack.isEmpty()Z" | ||
| ) | ||
| ) | ||
| private void onPlayerCollision_isEmpty(PlayerEntity player, CallbackInfo ci) { |
Contributor
There was a problem hiding this comment.
See above, don't have a great idea for this one though. If using underscores is just the style for this kind of inject it's reasonable enough, though it's not very descriptive about what exactly it's doing.
...-events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinServerPlayerEntity.java
Show resolved
Hide resolved
Member
|
Merge conflicts |
Conflicts: patchwork-events-entity/src/main/java/net/patchworkmc/impl/event/entity/EntityEvents.java
Contributor
Author
|
Conflicts solved |
Member
|
I'd like Leo's bikeshedding to be addressed and this is good to go |
Contributor
Author
|
suggestion applied |
Contributor
|
I'll deprecate my PR and work off this branch once its pulled. LGTM. |
TheGlitch76
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented PlayerEvents:
The rest of PlayerEvents will be implemented in a separate pr.