Fix increased effect of notables from time-lost jewels breaking notable tooltip #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1711 .
Description of the problem being solved:
Fixed issue that bnroke the tooltip of notables in the range of a time-lost jewel with the "#% Increased Effect of Notables" mod. Whenever a notable in range is hovered, the following error pops up:
Error: In 'OnFrame': Classes/PassiveTreeView.lua:1404: attempt to perform arithmetic on a boolean value stack traceback:Classes/PassiveTreeView.lua:1404: in function 'addModInfoToTooltip'Classes/PassiveTreeView.lua:1532: in function 'AddNodeTooltip'Classes/PassiveTreeView.lua:976: in function 'Draw'Classes/TreeTab.lua:393: in function 'Draw'Modules/Build.lua:1187: in function 'CallMode'Modules/Main.lua:375: in function <Modules/Main.lua:340>[C]: in function 'PCall'Launch.lua:111: in function <Launch.lua:108>v0.14.0 masterThis issue was fixed by ensuring the expression that caused the error evaluates to a number when
node.type~= "Normal".Steps taken to verify a working solution:
docker-compose upto verify changes didn't cause regression in existing functionality.Link to a build that showcases this PR:
Before screenshot:
After screenshot: