Fix Foulborn Choir of the Storm's Overcapped Mod not applying to Total Mana#9351
Merged
Wires77 merged 1 commit intoPathOfBuildingCommunity:devfrom Nov 25, 2025
Merged
Conversation
…for player as well
Wires77
approved these changes
Nov 25, 2025
OriginalThing
added a commit
to OriginalThing/PathOfBuilding
that referenced
this pull request
Jan 18, 2026
… to run for player as well (PathOfBuildingCommunity#9351)" This reverts commit f731c2b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9350
Description of the problem being solved:
Resistances are calc'ed after Life and Mana so for a mana/life scaled by resistance overcapped mod we need to run the LifeMana function again and thankfully we already do this for minions for the mod from Formless Inferno. This PR updates the logic to run for players as well.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Both items in an empty build
Random build from ninja that has FB Choir of the Storm
Before screenshot:
After screenshot: