Skip to content

Admin: Flag entity-related issues#1287

Merged
jvwong merged 5 commits intounstablefrom
iss1286_admin-flag-ungrounded
Jul 26, 2024
Merged

Admin: Flag entity-related issues#1287
jvwong merged 5 commits intounstablefrom
iss1286_admin-flag-ungrounded

Conversation

@jvwong
Copy link
Copy Markdown
Member

@jvwong jvwong commented Jul 24, 2024

Here I augment the admin/model to flag common entity-level issues:

  • ungrounded (non-complex) entities
  • mixed organisms (could signal orthologue issues)

Question: For convenience, I added an entity normalized method, but I can't recall what the difference is between associated and completed?

Refs #1286, part 'c'

@jvwong jvwong requested a review from maxkfranz July 24, 2024 14:55
normalized(){
// normalized := has a name and is associated
const name = this.syncher.get('name');
return name && this.associated() && this.completed();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what 'completed' was supposed to indicate?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

associated true (entity/node only) => grounded

completed (any element / node / edge) => the user has finished specifying the element

E.g. an interaction doesn't have a grounding but it can still be completed by specifying it as phosphorylation.

@jvwong
Copy link
Copy Markdown
Member Author

jvwong commented Jul 24, 2024

Admin page examples for (top) unnormalized entity (blocks public status) (bottom) mixed organisms (warning)
Screenshot 2024-07-24 at 11 21 47 AM

Copy link
Copy Markdown
Member

@maxkfranz maxkfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Suggestion for future: A filter at the top for these flagged, problematic documents would be nice so you don't have to hunt for them.

I suppose a submitted/not-public would be the same, but it's not as clear.

351774702-e181f6f8-d5ae-41ab-94c7-bf666c3cc6b8

@jvwong
Copy link
Copy Markdown
Member Author

jvwong commented Jul 26, 2024

Looks great.

Suggestion for future: A filter at the top for these flagged, problematic documents would be nice so you don't have to hunt for them.

Good point, there are some blocked (submitted) contributions that I never reviewed, missed.

Add this to a few other admin features required, based on things I'm doing manually:

@jvwong jvwong merged commit a474cb6 into unstable Jul 26, 2024
@jvwong jvwong deleted the iss1286_admin-flag-ungrounded branch July 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants