Merged
Conversation
jvwong
commented
Jul 24, 2024
| normalized(){ | ||
| // normalized := has a name and is associated | ||
| const name = this.syncher.get('name'); | ||
| return name && this.associated() && this.completed(); |
Member
Author
There was a problem hiding this comment.
Not sure what 'completed' was supposed to indicate?
Member
There was a problem hiding this comment.
associated true (entity/node only) => grounded
completed (any element / node / edge) => the user has finished specifying the element
E.g. an interaction doesn't have a grounding but it can still be completed by specifying it as phosphorylation.
Member
Author
maxkfranz
approved these changes
Jul 26, 2024
Member
Author
Good point, there are some blocked (submitted) contributions that I never reviewed, missed. Add this to a few other admin features required, based on things I'm doing manually:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Here I augment the admin/model to flag common entity-level issues:
Question: For convenience, I added an entity
normalizedmethod, but I can't recall what the difference is betweenassociatedandcompleted?Refs #1286, part 'c'