Fork and add TF12, Codebuild, and layer support#2
Merged
eyablonowitz merged 14 commits intopp_masterfrom Feb 20, 2020
Merged
Conversation
added 4 commits
February 5, 2020 21:21
eyablonowitz
force-pushed
the
layer
branch
2 times, most recently
from
48fb09c to
4c08096
Compare
terrancej
suggested changes
Feb 19, 2020
terrancej
left a comment
terrancej
left a comment
There was a problem hiding this comment.
Overall looks good a couple changes in the above comments. Potentially could be more to come once all wired up. Awesome job!
trobinsonpp
reviewed
Feb 19, 2020
eyablonowitz
force-pushed
the
layer
branch
2 times, most recently
from
f735b61 to
4f8ad9e
Compare
terrancej
approved these changes
Feb 20, 2020
terrancej
left a comment
terrancej
left a comment
There was a problem hiding this comment.
LGTM; layers work beautifully, i havent fully tested my function but looking to migrate to this module sometime today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module is forked from one created by the author of this blog post - https://amido.com/blog/terraform-does-not-need-your-code-to-provision-a-lambda-function/
The main purpose of using this module is to use Terraform to create Lambda resources but to host the Lambda code in another Git repo and deploy it using external CI.
I've updated the module as follows:\