PNGDAT-3207: Kno2 Add configuration to support delegation update (Clean-up)

[irsanchez]

Link to Ticket: https://hbuco.atlassian.net/browse/PNGDAT-3207

Summary by CodeRabbit

• Chores
  • Renamed the CloudWatch log subscription filter used for Lambda logging.
  • Added configuration for a destination and filter pattern to the subscription filter.
  • The destination now points to a Lambda-based log processor; the filter pattern is currently empty.
  • Infrastructure-only update with no changes to the user interface or workflows.

[coderabbitai]

Walkthrough

Renames the aws_cloudwatch_log_subscription_filter resource to lambda_log_subscription_filter in lambda_function/lambda_function.tf and adds destination_arn (pointing to a Lambda function) and an empty filter_pattern attribute.

Changes

Cohort / File(s)	Summary
Terraform: CloudWatch Logs subscription filter update lambda_function/lambda_function.tf	Renamed resource from example_subscription_filter to lambda_log_subscription_filter; added destination_arn referencing a Lambda function; added filter_pattern set to empty string.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant CW as CloudWatch Logs
    participant SF as Subscription Filter
    participant LF as Lambda Function

    Note over SF: Config updated: destination_arn + empty filter_pattern
    CW->>SF: Log events emitted
    SF->>LF: Forward matching events (empty filter = all)
    LF-->>CW: Processing result (async)
    Note over LF: Lambda invoked by Logs subscription

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• CAB-4856: Apply master-branch kno2-discharge-summary Terraform and check for drift #37: Also modifies aws_cloudwatch_log_subscription_filter naming/handling in the same file.
• CAB-4856: Apply master-branch kno2-discharge-summary Terraform and check for drift #38: Adjusts log_group_name handling for the same subscription filter resource.

Suggested reviewers

• smallesh90
• dhayespp

Poem

I tweaked the logs with careful hop,
A filter renamed—flip, plip, plop!
Events now leap to Lambda’s den,
Every squeak and byte, now and then.
Thump-thump, my paws approve this route—
Logs hop in, results hop out. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title mentions adding configuration to support a delegation update and fixing drift, which loosely corresponds to the new attributes added but does not clearly identify the specific resource or the main change of renaming and configuring the CloudWatch log subscription filter for Lambda. It is overly broad and does not convey the core updates such as adding destination_arn and filter_pattern to the aws_cloudwatch_log_subscription_filter resource.	Please revise the title to explicitly reference the CloudWatch log subscription filter changes, for example: “Add destination_arn and filter_pattern to aws_cloudwatch_log_subscription_filter for Lambda,” so that the primary modifications are clear at a glance.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch PNGDAT-3207-filtername

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c76bdc and 6ff04d3.

📒 Files selected for processing (1)

• lambda_function/lambda_function.tf (1 hunks)

🔇 Additional comments (1)

lambda_function/lambda_function.tf (1)

16-17: Confirm supporting data sources exist

destination_arn now references data.aws_region.current and data.aws_caller_identity.current. If those data sources aren’t already defined within this module, Terraform will fail to plan/apply. Please confirm they exist (or add them, e.g. data "aws_region" "current" {} / data "aws_caller_identity" "current" {}).

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}