Switch to six

[lynneatan]

Add six module, update version and imports

[emosesPatreon]

Leave 0.5.0 in place, and add 0.5.1 above it.

Here's an example: https://github.com/Patreon/patreon-js/blob/master/changelog.md

[emosesPatreon]

What exactly does this do? I was looking at the docs for six, and it just shows text_type as a constant, not a function.

[lynneatan]

It converts the text into unicode string for python two and str for python3
Eg:
In python two :

x = six.text_type('hello')
x
u'hello'

In python three:

x = six.text_type('hello')
x
'hello'

[emosesPatreon]

K. I think you don't need it to add it everywhere in the tests. It's actually probably a good idea to *not* add it everywhere in the tests, because consumers will *not* be using it. Instead, make sure it's everywhere it needs to be in the code, and run the tests in both 2.x and 3.x. Let me know if you need help with pyenv and virutalenv to set up different execution environments.

…

On Wed, May 16, 2018 at 4:37 PM, Lynnea Tan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In patreon/api_spec.py <#22 (comment)>: > @@ -23,7 +25,7 @@ def api_url(*segments, **query): - path = '/'.join(map(str, segments)) + path = six.text_type('/').join(map(six.text_type, segments)) It converts the text into unicode string for python two and str for python3 Eg: In python two : x = six.text_type('hello') x u'hello' In python three: x = six.text_type('hello') x 'hello' — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ak6MKd9CqR8mqfZZigc1bMUvnZl7l4Ayks5tzLgdgaJpZM4UB5j3> .

-- Evan Moses emoses@patreon.com