Fix installation scripts for new repo location#6
Merged
PatrickRuddiman merged 1 commit intomainfrom Jun 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the installation scripts to reflect the new repo location while also improving asset naming, error messages, and cleanup handling. Key changes include updating repo URLs across bash and PowerShell scripts, unifying asset naming conventions, and adding cleanup traps for temporary directories.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| install.sh | Combined the dotnet publish and installation commands for brevity. |
| install-web.sh | Updated repo URL and asset naming; added cleanup traps for temporary dirs. |
| install-web.ps1 | Updated repo URL in usage comments and configuration. |
| install-universal.sh | Updated repo URL and asset naming; added a cleanup trap but also retained an explicit removal of the temporary directory. |
|
|
||
| # Cleanup | ||
| cd - > /dev/null | ||
| rm -rf "$TEMP_DIR" |
There was a problem hiding this comment.
The explicit removal of the temporary directory is redundant since a cleanup trap is already in place. Removing this duplicate call will simplify the script.
Suggested change
| rm -rf "$TEMP_DIR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shTesting
shellcheck install-universal.sh install-web.sh install.shbash -n install-universal.sh install-web.sh install.shpwsh -NoLogo -NoProfile -Command "Import-Module PSScriptAnalyzer; Invoke-ScriptAnalyzer -Path install-web.ps1 -Severity Error"pwsh -NoLogo -NoProfile -Command "Import-Module PSScriptAnalyzer; Invoke-ScriptAnalyzer -Path install.ps1 -Severity Error"dotnet build Write-Commit.slnbash install-web.sh --version v0.1.3 --install-dir /tmp/writecommit_testbash install-universal.sh --arch linux-x64https://chatgpt.com/codex/tasks/task_e_6860609831e0832a852f628b84f38cc9