Skip to content

fix: Fix an issue where the link context menu wasn't opened anymore. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thet merged 1 commit into from
Jul 4, 2025
Merged

fix: Fix an issue where the link context menu wasn't opened anymore. #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export function init({ app, button }) {
app.editor.isActive("link")
? button.classList.add("active")
: button.classList.remove("active");
app.editor.can().setLink()
app.editor.can().setLink({})
? button.classList.remove("disabled")
: button.classList.add("disabled");

Expand Down
61 changes: 61 additions & 0 deletions src/tiptap.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ describe("pat-tiptap", () => {
data-pat-tiptap="
toolbar-external: #tiptap-external-toolbar;
link-panel: #link-panel;
link-menu: #context-menu-link;
link-extra-protocols: fantasy;
">
</textarea>
Expand All @@ -409,6 +410,20 @@ describe("pat-tiptap", () => {
class="close-panel">submit</button>
</form>
</template>
<template id="context-menu-link">
<div class="tiptap-link-context-menu">
<a
class="close-panel tiptap-open-new-link"
target="_blank"
href="">Visit linked web page</a>
<button
type="button"
class="close-panel tiptap-edit-link">Edit link</button>
<button
type="button"
class="close-panel tiptap-unlink">Unlink</button>
</div>
</template>
`;
const pattern = new Pattern(document.querySelector(".pat-tiptap"));
await events.await_pattern_init(pattern);
Expand Down Expand Up @@ -506,6 +521,52 @@ describe("pat-tiptap", () => {
expect(anchor.href).toBe("fantasy://patternslib.com");
expect(anchor.textContent).toBe("Link text");
});

it("5.8 - Opens a link context menu", async () => {
// Add a link to test the context menu on.
document.querySelector("#link-panel [name=tiptap-href]").value = "https://patternslib.com"; // prettier-ignore
document.querySelector("#link-panel [name=tiptap-text]").value = "Link text"; // prettier-ignore
document.querySelector("#link-panel [name=tiptap-confirm]").dispatchEvent(new Event("click")); // prettier-ignore
await utils.timeout(1);

const editable = document.querySelector(
".tiptap-container [contenteditable]",
);
const range = document.createRange();
const sel = window.getSelection();

// Add the triggering character into the content editable
editable.innerHTML = "<p>@</p>";

// Set the cursor right after the @-sign.
range.setStart(editable.childNodes[0].childNodes[0], 1);
range.collapse(true);
sel.removeAllRanges();
sel.addRange(range);

// Wait some ticks.
await utils.timeout(1);
await utils.timeout(1);

// Context menu not yet opened.
expect(document.querySelector(".tiptap-link-context-menu")).toBeFalsy();

// Context menu opens with a 50ms delay.
await utils.timeout(50);

// Context menu should be opened now.
expect(document.querySelector(".tiptap-link-context-menu")).toBeTruthy();

// Wait two more ticks for the context menu to be fully initialized.
await utils.timeout(1);
await utils.timeout(1);

// UI elements should be initialized now.
expect(
document.querySelector(".tiptap-link-context-menu .tiptap-open-new-link")
.href,
).toBe("https://patternslib.com/");
});
});

it("6.1 - Adds an image within <figure> tags including a <figcaption>", async () => {
Expand Down