Closed
Conversation
Author
|
Just a quick update - verified changes work on a ESP32-C3 and a ESP32-S2 |
melvinm1
added a commit
to melvinm1/ConfigurableFirmata
that referenced
this pull request
Jul 26, 2023
|
@mjs513 I tried your fork today with a R4 WIFI, but sadly, it does not work. I even used a basic example to make sure, it is not an error I introduced in my code. Both variants, with interrupts or not don't give any results. The encoder itself works fine with the original library and a UNO R3. Do you have an idea how I could start debugging whats happening? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PaulStoffregen - @KurtE
When trying to update the library for the new R4 boards (Minima and WiFi) ran into an issue where attaching the interrupt did not work. Thanks to @KurtE found that the issue was with doing it from the constructor which took a while to track down. But he came up with a simple solution that maintains backward compatibility. More can found here: https://forum.arduino.cc/t/encoder-library-attachinterrupt-not-working-from-within-library/1149007
Basically creates a begin method that can be used but when you begin:
This can be used for any board. This method still works though:
without using begin in the setup.
I did try it with a Teensy 4.1, Uno, Mega, Nano 33 IoT, and adafruits metro Express m0 board.