Skip to content

Conversation

@xecdev
Copy link
Collaborator

@xecdev xecdev commented May 20, 2025

This PR fixes #63 by correcting the nonce logic for Customers and Content pages table sorting.

Test plan:

  • Install and activate the updated plugin
  • Go to Customers and Content pages → pages should render normally (no nonce check)
  • Now in either Customers page or the Content page, sort the table by clicking a column from the table
  • Once the page refereshes, the URL will now include the nonce, temper with it (or remove it from the URL) and you will see → “Security check failed”.
  • As a non-admin, visit those admin pages using URL (with or without params) → no access.

@xecdev xecdev requested a review from Klakurka May 20, 2025 06:43
@xecdev xecdev self-assigned this May 20, 2025
@xecdev xecdev added the bug Something isn't working label May 20, 2025
@xecdev
Copy link
Collaborator Author

xecdev commented May 20, 2025

Ready for review

@Klakurka Klakurka merged commit 2300679 into master May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nonces and User Permissions Needed for Security

3 participants