update readme #79
update readme #79
Conversation
WalkthroughVersion and dependency metadata updated: plugin header bumped to 4.0.0, README changelog and upgrade notice added for 4.0.0 (no-reload unlocks, auto-closing payment dialog, PayButton client v5.0.2). Script version strings updated to v5.0.2 in admin and public asset enqueues. No API or behavioral code changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.txt (2)
77-81: Changelog entry reads well; consider noting any BC considerations.If no template/JS API changes are expected, add a short “No breaking changes” note to set expectations. If there are behavioral tweaks (auto-close), briefly mention any callbacks/events that changed.
136-137: Make the Upgrade Notice more actionable.Suggest clarifying what’s new and any admin steps (e.g., clear caches), since users see only this in the updater UI.
Apply this minimal tweak:
-= 4.0.0 = -Upgrade to version 4.0.0 for improved compatibility and reliability. += 4.0.0 = +Upgrade for no-reload content unlocks, auto-closing payment dialog, and the embedded PayButton client v5.0.2. After updating, clear site/server caches to ensure new assets load.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.txt(3 hunks)paybutton.php(1 hunks)
🔇 Additional comments (1)
paybutton.php (1)
5-5: Version bump aligned; ensure release tagging.Header shows 4.0.0. Looks good alongside README’s stable tag.
Before merging, please:
- Create a Git tag v4.0.0 and a WordPress.org SVN tag 4.0.0.
- Confirm the plugin assets (banner/README) are present in the 4.0.0 tag.
| Stable tag: 4.0.0 | ||
| PayButton Client: 5.0.2 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Stable tag and client version bump look good; verify the enqueued asset actually uses 5.0.2.
Run to confirm what version is enqueued/bundled:
🏁 Script executed:
#!/bin/bash
# Find PayButton client references and versions
rg -nP -C2 '(wp_enqueue_script|wp_register_script)\s*\(|paybutton(\.min)?\.js|PayButton Client|5\.0\.2'
# If bundled, list files that look like the client build
fd -t f -i 'paybutton*.js' | xargs -I{} sh -c 'echo "=== {} ==="; head -n 3 "{}"; echo'Length of output: 59717
Update enqueued PayButton script version to 5.0.2
- In includes/class-paybutton-public.php, change the version argument on the wp_enqueue_script call for assets/js/paybutton.js (from '1.0' to '5.0.2').
- In includes/class-paybutton-admin.php, do the same for the admin enqueue of assets/js/paybutton.js (change '1.0' to '5.0.2').
🤖 Prompt for AI Agents
In README.txt around lines 8-9 and in includes/class-paybutton-public.php and
includes/class-paybutton-admin.php (search for wp_enqueue_script calls for
assets/js/paybutton.js), update the version argument from '1.0' to '5.0.2' so
the enqueued script version matches the PayButton Client; locate the
wp_enqueue_script(...) calls in both public and admin classes and change the
version parameter to '5.0.2', then run a quick test to confirm cache-busting
works as expected.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
includes/class-paybutton-public.php (2)
69-75: Centralize PayButton client version to avoid driftDefine a single constant and reuse it in admin/public enqueues to keep README, code, and assets in sync.
Apply within this file:
- '5.0.2', + PAYBUTTON_CLIENT_VERSION,Add once (e.g., in paybutton.php bootstrap):
if ( ! defined( 'PAYBUTTON_CLIENT_VERSION' ) ) { define( 'PAYBUTTON_CLIENT_VERSION', '5.0.2' ); }
69-75: Consider loading core in footer for better page performanceIf nothing depends on
paybutton-corein the head, enqueue it in the footer.- false + truePlease verify no head-time consumers of
paybutton-coreexist.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
includes/class-paybutton-admin.php(1 hunks)includes/class-paybutton-public.php(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- includes/class-paybutton-admin.php
🧰 Additional context used
🧬 Code graph analysis (1)
includes/class-paybutton-public.php (1)
assets/js/paybutton.js (1)
function(){}(1-1)
🔇 Additional comments (1)
includes/class-paybutton-public.php (1)
69-75: LGTM: version bump to 5.0.2 for cache-bustingThe enqueue change looks correct and aligns with the release notes.
As per title
Summary by CodeRabbit