Conversation
Andrew-Paystack
commented
Jan 23, 2026
Andrew-Paystack
commented
- Updates the Paystack client request
- Adds test secret key check
damilola-paystack
left a comment
damilola-paystack
left a comment
There was a problem hiding this comment.
I left some comments
| @@ -0,0 +1,23 @@ | |||
| export interface PaystackResponse<T = any> { | |||
There was a problem hiding this comment.
Hey @Andrew-Paystack, is there a reason for generic here if it defaults to any?
src/resources/index.ts
Outdated
| let pattern = r.definition.uri.replace(/\{[^}]+\}/g, '(.+)'); | ||
|
|
||
|
|
||
| pattern = pattern |
There was a problem hiding this comment.
@Andrew-Paystack what are we trying to achieve here? It feels like we are over-engineering here
| * Redact sensitive fields in card objects | ||
| * Only redacts cvv and number, keeps other fields visible | ||
| */ | ||
| function redactCardObject(card: any): any { |
There was a problem hiding this comment.
Is this function being used? If so how is it being used? There's no endpoint that allows passing card details and responses containing card details are masked already
There was a problem hiding this comment.
@damilola-paystack the function is called in the redactSensitiveData part and it just checks if someone has passed a card object.
damilola-paystack
left a comment
damilola-paystack
left a comment
There was a problem hiding this comment.
I guess we still need to clean up later, so let's merge and review further when the initial features are done
2 participants
