Skip to content

Conversation

@devpatel516
Copy link

This Pull Request addresses the request to add specific species to the CRID (Crop ID) dictionary for field activity tracking, particularly for events related to Höja, Sweden.

The following species have been added to the dictionary file:
Blodklöver (Trifolium incarnatum) — Code: TRIIN
Humlelusern (Medicago lupulina) — Code: MEDLU
Svartkämpar (Plantago lanceolata) — Code: PLALA

Changes Made:
Dictionary Update: Appended three new rows to the dictionary file under the CRID category.
Standardization: Used standard 5-letter codes and included both English and Swedish common names in the display field for better usability in the Swedish context.

Linking the Issue:
Closes #57

@HenriKajasilta
Copy link
Collaborator

Hey,

Thanks for contributing. We can certainly add these species, but there are actually a couple of things we need to fix first. I will list my concerns below

  • There are extra columns in display_names.csv in your pull request, please check the formatting.
  • As we do not have columns for Swedish names, the corresponding species names in Finnish (disp_name_fin) should be veriapila (instead of blodklöver), nurmimailanen (instead of humlelusern) and heinäratamo (instead of svartkämpa). This was unfortunately not noted in the issue.
  • Could you please explain how the codes were created and whether they are related to the ICASA dictionary? If not, I would prefer a three-letter abbreviation if possible. You can check the examples of other species in the same file. Also, please move these rows together with the other CRID codes.
  • The branch dev is the most up to date and in production, so please, point your pull request to that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding new species

2 participants