Skip to content

Conversation

@DongchenZ
Copy link
Contributor

@DongchenZ DongchenZ commented Feb 21, 2025

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

}
if (replace | nchar(Sys.getenv("ed_un")) == 0 | nchar(Sys.getenv("ed_un")) == 0) {
Sys.setenv(ed_un = sprintf(
getPass::getPass(msg = "Enter NASA Earthdata Login Username \n (or create an account at urs.earthdata.nasa.gov) :")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version seems to require that the system is run interactively. Would there be value in retaining the ability to load authentication from the netrc file? Or could there be instructions on how to run the function prior to execution to set the environment variables? What if the execution is remote (e.g., in the cloud or on a HPC node) where there are different environment variables? Is there a security issue with having passwords stored unencrypted as part of the environment variables? Curious what @robkooper thinks.

@mdietze mdietze enabled auto-merge March 2, 2025 13:44
@mdietze mdietze added this pull request to the merge queue Mar 20, 2025
Merged via the queue into PecanProject:develop with commit b5322a0 Mar 20, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants