Skip to content

Conversation

@S1DDHEY
Copy link
Contributor

@S1DDHEY S1DDHEY commented Jan 5, 2026

Description

fixes #3738
This PR updates ggplot2 calls to replace the deprecated size argument with linewidth, in order to remove deprecation warnings

Files updated

  • modules/data.atmosphere/R/debias_met_regression.R
  • modules/uncertainty/R/plots.R
  • shiny/ForecastingDashboard/animated_WCr_graphs.R
  • shiny/ViewMet/server.R

Testing

I locally tested modules/uncertainty (with testthat) and modules/data.atmosphere (with test.met.process.R, test.metutils.R), wasn't able to test for changes done undershiny/

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@mdietze mdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend also removing the error messages from the log files to prevent reversions

@infotroph
Copy link
Member

Thanks for doing this!

  • No action needed for @mdietze's request -- These are runtime warnings, so they don't show up in the check logs.
  • You can ignore the Docker GHA CI failures -- these were broken already
  • To fix the CI/check failure, please edit shiny/ViewMet/DESCRIPTION to add a line that says Version: 0.0.0.9000.

@S1DDHEY
Copy link
Contributor Author

S1DDHEY commented Jan 7, 2026

@infotroph I see now that the CI failures are due to the version check for modules/data.atmosphere rather than branch history. Should I just push a version bump in the DESCRIPTION file of modules/data.atmosphere to get rid of this ?

@infotroph
Copy link
Member

Yes, please bump the version of data.atmosphere -- you get to be the first person to update it after yesterday's release!

@infotroph infotroph added this pull request to the merge queue Jan 7, 2026
Merged via the queue into PecanProject:develop with commit 187be52 Jan 7, 2026
19 of 25 checks passed
@S1DDHEY S1DDHEY deleted the fix/ggplot2-deprecation-warning branch January 7, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ggplot2 ≥ 3.4.0 deprecation warnings due to size aesthetic in plotting code

3 participants