Skip to content

Conversation

@robkooper
Copy link
Member

@robkooper robkooper commented Jan 6, 2026

docker.sh now mimics the github action closer
added fix for ed building, now uses the same setup as official ED repository docker build

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

docker.sh now mimics the github action closer
@robkooper robkooper requested a review from infotroph January 6, 2026 13:54
@github-actions github-actions bot added the Models label Jan 6, 2026
@mdietze mdietze merged commit 2663aa1 into release/v1.10.0 Jan 6, 2026
32 of 33 checks passed
@infotroph infotroph deleted the docker-ed-fix branch January 7, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants