-
Notifications
You must be signed in to change notification settings - Fork 20
Corrections and clarifications to heterotrophic respiration scheme #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the heterotrophic respiration equations in the model documentation by properly separating litter and soil respiration components. The key fix addresses an error where the respiration fraction parameter
Key Changes:
- Reformulated the heterotrophic respiration equation to explicitly separate soil and litter respiration components
- Clarified that litter decomposition is partitioned between respiration and soil carbon transfer using
$f_{\text{litter}}$ - Updated parameter tables to improve notation consistency and remove deprecated/unused parameters
- Cleaned up documentation by removing commented-out sections and consolidating parameter descriptions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/parameters.md | Renamed "Litter Quality Parameters" to "Stoichiometry Parameters", updated parameter symbols (including |
| docs/model-structure.md | Restructured heterotrophic respiration section to separate litter and soil components, added new equations (4a, 4b) to clarify litter decomposition partitioning, rewrote explanatory text for improved clarity, and removed the old combined respiration equation that incorrectly applied |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
A couple of minor comments:
|
|
Hmmm, hold on, mis-read... Don't the two R_H_litter calcs - (5) and last part of (7) - contradict each other? |
|
One more - I think harvest plays in to dC_soil/dt (eq Braswell A3), unless we are implicitly including it in the belowground plant turnover. |
| $F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity. | ||
|
|
||
| The flux of carbon from plant biomass to the litter pool is the sum of litter produced through aboveground senescence, transfer of biomass during harvest, and organic matter amendments: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant with the paragraph above, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. Fixed in 16bd4be
docs/model-structure.md
Outdated
|
|
||
| Where $F^C_\text{litter}$ is the carbon flux from aboveground plant biomass into the litter pool through senescence, harvest transfer, and organic matter additions \eqref{eq:litter_flux}. Belowground turnover is routed directly to the soil carbon pool (see Soil Carbon). | ||
| $F^C_{\text{decomp}}$ is the total carbon flux lost from the litter pool due to decomposition and includes both transfer and respiration \eqref{eq:decomp_carbon}. | ||
| $F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity. | |
| $F^C_{\text{decomp}}$ is the total litter decomposition flux, representing the rate at which litter carbon is processed by microbial activity prior to partitioning among downstream fluxes. | |
Description
Based on conversation today, this equation was incorrect because the$f_\text{litter}$ only applies to litter, not to soil (since decomposed soil is either respired or stays in the soil pool).
In addition to clarifying and fixing heterotrophic respiration, I also clarified the section and fixed typos and other inconsistencies.
This was incorrect
Correct (🤞🏻):
Side note on notation
Currently, fluxes are (hopefully consistently) indexed by their destination pool, but this is ambiguous e.g.:
is the flux to soil, but could refer to flux from roots, litter, or OM additions. I've changed some of these to use
notation but perhaps it would be more clear to make it
If so I can write this up as perhaps a 'good first issue' to follow #203.