Merged
Conversation
Change ELEVEN_LABS_API_KEY to ELEVENLABS_API_KEY to match the deployment configuration in GitHub Actions workflows. Closes #129 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace hardcoded "spanish"/"latin" string matching with dynamic language name lookup. Now correctly detects translation direction for all supported languages including Icelandic. Closes #130 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add getExerciseFeedback() utility for language-specific success/failure messages - Update FillBlankExercise, MultipleChoiceExercise, and TranslationExercise to accept language prop and display localized feedback - Update ExercisesRegion to pass language prop to exercise components Feedback by language: - Spanish: ¡Correcto! / No del todo - Latin: Recte! / Non recte - Icelandic: Rétt! / Ekki alveg Closes #131 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
Ready for ReviewAll automated tests pass. UAT steps are documented in the PR description. Quick Verification Checklist
UAT Summary
|
- Add dark mode variants to NotificationSettings component (alerts, status boxes) - Add dark mode variants to PWAInstallBanner component - Add dark mode variants to Flashcards deck management page (25+ fixes) - Add dark mode variant to Flashcards practice page (mark element) - Replace text-sepia-* with semantic text-foreground/text-muted-foreground - Add E2E tests for multi-language exercise feedback Closes #133 (related diagnosis) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace min-h-screen with min-h-[100dvh] for dynamic viewport height - Remove redundant min-h-screen from nested mobile dashboard container - Update hub-container and classic-container CSS classes - Add pb-8 to mobile dashboard for proper bottom spacing The 100dvh unit uses dynamic viewport height which properly accounts for mobile browser chrome (address bar) appearing/disappearing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
✅ UAT CompleteTests PerformedBug #129: ElevenLabs TTS
Bug #130: Exercise Direction Detection
Bug #131: Training Ground Feedback
Additional Testing
Environment
Ready to merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple language awareness issues in the application:
ELEVEN_LABS_API_KEYtoELEVENLABS_API_KEYto match deployment configCloses
Closes #129
Closes #130
Closes #131
Changes
app/api/tts/synthesize/route.tsapp/api/lessons/[lessonId]/generate-from-reading/route.tslib/languages/index.tsgetExerciseFeedback()utilitycomponents/exercises/*.tsxlanguageprop, use localized feedbackcomponents/hub/ExercisesRegion.tsxTest Plan
Automated Tests
Manual UAT Steps
Bug #129: ElevenLabs TTS
Bug #130: Exercise Direction Detection
directionfield should beis_to_enoren_to_is, NOT containing 'spanish' or 'latin'Bug #131: Training Ground Feedback
Navigate to Training Ground for a Spanish lesson
Complete an exercise correctly
Expected: See "¡Correcto!" feedback
Navigate to Training Ground for a Latin lesson
Complete an exercise correctly
Expected: See "Recte!" feedback
Navigate to Training Ground for an Icelandic lesson
Complete an exercise correctly
Expected: See "Rétt!" feedback
🤖 Generated with Claude Code