fix(penify_hook): handle git ancestor detection

[sumansaurabh]

User description

This update introduces a fix for the issue where the application would throw an error if the selected folder did not contain a .git directory, but its ancestor did. The find_git_parent function has been added to the utils.py module to traverse up the directory tree and locate the nearest .git folder. This enhancement ensures that the application can correctly identify the Git repository in parent directories, improving usability and preventing runtime errors related to Git operations.

---

Description

• Introduced find_git_parent function to traverse up the directory tree and locate the nearest .git folder.
• Updated the main function to utilize this new function, improving usability by preventing errors when the selected folder lacks a .git directory.
• Added a custom exception GitRepoNotFoundError for better error handling when no Git repository is found.

---

Changes walkthrough 📝

Relevant files

Bug fix

main.py Integrate Git ancestor detection in main function                penify_hook/main.py Imported find_git_parent function from utils.py. Updated main function to use find_git_parent for determining the Git folder path. +3/-0      utils.py Add utility function for Git ancestor detection                    penify_hook/utils.py Added GitRepoNotFoundError exception class. Implemented find_git_parent function to locate the nearest .git directory. +14/-0

---

💡 Penify usage:
Comment /help on the PR to get a list of all available Penify tools and their descriptions

[penify-dev]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve adding a utility function and modifying the main function with minimal complexity.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The find_git_parent function raises a GitRepoNotFoundError if no .git directory is found. Ensure that this exception is handled appropriately in the main function to avoid unhandled exceptions during runtime.
🔒 Security concerns	No

[penify-dev]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Validate the existence of the provided path before processing it Consider adding a check for the existence of the path before attempting to traverse it in find_git_parent to avoid unnecessary errors. penify_hook/utils.py [7] +if not os.path.exists(path): + raise GitRepoNotFoundError(f"The provided path does not exist: {path}") current_dir = os.path.abspath(path) Suggestion importance[1-10]: 9 Why: This suggestion improves the function's reliability by ensuring that the path exists before processing, which can prevent runtime errors.	9
Possible bug	Add validation for the git folder path before calling the function Ensure that find_git_parent handles cases where args.git_folder_path is None or an invalid path before proceeding to avoid potential runtime errors. penify_hook/main.py [292] -args.git_folder_path = find_git_parent(args.git_folder_path) +if args.git_folder_path: + args.git_folder_path = find_git_parent(args.git_folder_path) +else: + print("Error: git_folder_path is not provided.") + sys.exit(1) Suggestion importance[1-10]: 8 Why: This suggestion addresses a potential runtime error by validating the input before calling the function, which is crucial for robustness.	8
Enhancement	Enhance the error message for clarity and debugging purposes Improve the error message in GitRepoNotFoundError to include the original path for better debugging. penify_hook/utils.py [14] -raise GitRepoNotFoundError(f"No Git repository found in the path or any of its parent directories: {path}") +raise GitRepoNotFoundError(f"No Git repository found in the path '{path}' or any of its parent directories.") Suggestion importance[1-10]: 7 Why: Enhancing the error message improves debugging capabilities, although it does not address a critical issue.	7
Performance	Optimize the path handling by reducing redundant calls to os.path.abspath Consider using os.path.abspath only once when determining the current directory to optimize performance. penify_hook/utils.py [7-12] -current_dir = os.path.abspath(path) +current_dir = path while current_dir != os.path.dirname(current_dir): + current_dir = os.path.abspath(current_dir) Suggestion importance[1-10]: 6 Why: While this suggestion optimizes performance by reducing redundant calls, it is a minor improvement compared to the other suggestions.	6