Open
Conversation
…s as well as dynamo events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the dynamo event store. Now put_event queues an event for persistence and returns control to the calling process. Periodically the process sends a message to remind itself to persist the events it has collected. Passes the (modified) tests but needs additional tests to expose how dynamo handles payloads greater than the batch-write limit.
Should get_event check pending events before submitting the request to dynamo? Probably. I had to add waits to the tests to prevent "eventual consistency" failures.
Ignore the 1ms interval, that was from my testing. I would like to provide a way to configure the interval to persist.
Getters are still static code that blocks the calling process, which would have to change if it checked the pending events.