-
Notifications
You must be signed in to change notification settings - Fork 55
Tweak outreach map #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NataKilar
merged 66 commits into
PersistentSS13:dev
from
PsyCommando:tweak-outreach-map
Dec 15, 2023
Merged
Tweak outreach map #380
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
703725f
map change
PsyCommando 28a2997
recycler wip
PsyCommando 5e0280e
kleibkhar map
PsyCommando a34ac04
geothermal
PsyCommando 4007c91
kleibkhar stuff
PsyCommando 3561985
Update designs_misc_circuits.dm
PsyCommando 3a30858
Overmap handling changes
PsyCommando 5be57bf
Added vent pump variants
PsyCommando 10780f5
materials
PsyCommando 481c290
add test skipping
PsyCommando 3264efa
new sound effects
PsyCommando 1aa01b1
removed old overmap override
PsyCommando 786e744
Outreach Map
PsyCommando 739a4f8
Update chargen_areas.dm
PsyCommando 3c26de1
outreach level stuff
PsyCommando d48d521
shuttle template
PsyCommando c01b647
icons
PsyCommando ed8f85f
Update folding.dm
PsyCommando 5bfaf09
Minor decoration + furnishing
PsyCommando c920157
Update outreach-1.dmm
PsyCommando 96797c3
recycler fixed
PsyCommando 0128e00
Added a lot of dirt
PsyCommando d74f761
fixed some decals missing icons
PsyCommando f20897e
merge fixes
PsyCommando 6a9da17
Moved outreach to map_template
PsyCommando 3677faf
Cleaned up turf types.
PsyCommando 553a717
linter hates comments in lists
PsyCommando 9e2c524
Fix compilation after merge
PsyCommando 2e33cc2
Mining use midnight rollover checked timeofday
PsyCommando dd1dd87
Update recycler.dm
PsyCommando c9946d5
Compile fix outreach
PsyCommando 1d1322b
Properly use constants for network name
PsyCommando c1cba05
Use constants for protected area definition
PsyCommando c0c0911
Update outreach_areas.dm
PsyCommando de7ed4f
fix poster offset
PsyCommando c1bbc7b
fix crema switch
PsyCommando 6aff2ad
Fix really shady override of sequential ids
PsyCommando 3106a6e
move network stuff to own file
PsyCommando 2c36f3f
Update recycler.dm
PsyCommando efc4bce
guids include in neb
PsyCommando dd4cefc
Moved helper code to inside modpack
PsyCommando ed19706
remove old strata var
PsyCommando d08b4e2
docking controller nuked
PsyCommando 368bed5
Make turbolift generate last
PsyCommando 3e3be14
properly offset wall recharger
PsyCommando cf33d68
Properly offset wall dispensers
PsyCommando 2145997
comment sequential guid gen
PsyCommando 6cd4a11
godmode check on fire acts
PsyCommando a6394fc
Don't save mimic edges
PsyCommando 3327413
Update outreach_elevators.dm
PsyCommando 54d0c46
Merge remote-tracking branch 'upstream/dev' into tweak-outreach-map
PsyCommando 88e51b0
Update outreach-4.dmm
PsyCommando b1f3f4a
satisfy mapping gods
PsyCommando 24a3caa
Update outreach_south-2.dmm
PsyCommando a3c6c2b
added missing unit test overrides
PsyCommando 5be703c
fixes missing species
PsyCommando 9a604e4
fix duplicate catwalk spawning
PsyCommando 79cb5fd
formatting changes
PsyCommando a412966
Get area tests to behave
PsyCommando 3bb3f97
Fix missing scrubber
PsyCommando f2ebce3
Some area fixes
PsyCommando bee92de
Fix list error during unit tests
PsyCommando 8e9f9a8
Fix internet uplink templates
PsyCommando 5770cf9
Update outreach_test.dm
PsyCommando dae51fd
Test
PsyCommando 7345a84
Merge remote-tracking branch 'upstream/dev' into tweak-outreach-map
PsyCommando File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| ////////////////////////////////////////////////////////// | ||
| // Material Powder | ||
| ////////////////////////////////////////////////////////// | ||
|
|
||
| ///A powdered form of a material, meant to be used in further processing and useless for construction and crafting | ||
| /obj/item/stack/material/dust | ||
| name = "powder pile" | ||
| desc = "Some powdered matter." | ||
| singular_name = "pile" | ||
| plural_name = "piles" | ||
| icon_state = "lump" | ||
| plural_icon_state = "lump-mult" | ||
| max_icon_state = "lump-max" | ||
| w_class = ITEM_SIZE_LARGE //Bulky | ||
| melee_accuracy_bonus = -50 | ||
| throw_speed = 1 | ||
| throw_range = 2 | ||
| does_spin = FALSE //Doesn't spin when thrown | ||
| max_amount = 1000 //Each dust pile is 200 units each, while normal sheets are 2,000 units each. This means we get the same amount in a full stack. | ||
| matter_multiplier = 0.1 | ||
| abstract_type = /obj/item/stack/material/dust | ||
| is_spawnable_type = FALSE | ||
| pickup_sound = 'sound/foley/pebblespickup1.ogg' | ||
| drop_sound = 'sound/foley/pebblesdrop1.ogg' | ||
| attack_verb = list("splattered", "sprinkled", "dredged") | ||
|
|
||
| //We don't allow people to build anything from this, its just an intermediate material | ||
| /obj/item/stack/material/dust/list_recipes(mob/user, recipes_sublist) | ||
| return | ||
|
|
||
| /obj/item/stack/material/dust/throw_impact(atom/hit_atom, datum/thrownthing/TT) | ||
| . = ..() | ||
|
|
||
| //Chop down the stack into a bunch of smaller stacks | ||
| var/min_amount_needed = round(max_amount * (rand(5, 9) * 0.1)) //pick an amount to stop at between 50-90% of the stack left | ||
| while(amount > min_amount_needed && can_split()) | ||
| var/percent_to_split_off = rand(20, 70) * 0.01 | ||
| split(CEILING(percent_to_split_off * amount)) | ||
|
|
||
| //Then try to apply a dusting of us onto whatever we hit | ||
| var/datum/reagents/R = new(CELL_VOLUME, global.temp_reagents_holder) | ||
| for(var/mtype in matter) | ||
| var/amount = matter[mtype] | ||
| if(amount) | ||
| R.add_reagent(mtype, amount * REAGENT_UNITS_PER_MATERIAL_UNIT) | ||
| if(R.total_volume > 0) | ||
| R.splash(hit_atom, R.total_volume) | ||
| use(amount) | ||
|
|
||
| // Dust override | ||
| /decl/material | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instinct tells me this should be in the base material file, but the Neb maints can decide once/if it goes upstream |
||
| var/powder_type = /obj/item/stack/material/dust | ||
|
|
||
| /decl/material/proc/place_dust(var/atom/target, var/matter_units, var/allow_partial_stacks = TRUE) | ||
| if(!powder_type && matter_units <= 0) | ||
| return | ||
| var/list/powder_mat = atom_info_repository.get_matter_for(powder_type, type, 1) | ||
| var/amount_per_pile = LAZYACCESS(powder_mat, type) | ||
| if(amount_per_pile < 1) | ||
| return | ||
|
|
||
| //Make all the shards we can | ||
| var/piles_amount = round(matter_units / amount_per_pile) | ||
| var/matter_left = round(matter_units % amount_per_pile) | ||
| LAZYADD(., create_object(target, piles_amount, powder_type)) | ||
|
|
||
| //If we got more than expected, just make a shard with that amount | ||
| if(allow_partial_stacks && matter_left > 0) | ||
| var/list/O = create_object(target, 1, powder_type) | ||
| var/obj/S = O[O.len] | ||
| LAZYSET(S.matter, type, matter_left) | ||
| LAZYADD(., S) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -485,6 +485,11 @@ | |
| /datum/fabricator_recipe/imprinter/circuit/photocopier | ||
| path = /obj/item/stock_parts/circuitboard/photocopier | ||
|
|
||
| /datum/fabricator_recipe/imprinter/circuit/geothermal_generator | ||
| path = /obj/item/stock_parts/circuitboard/geothermal | ||
|
|
||
| /datum/fabricator_recipe/imprinter/circuit/radiocarbon_spectrometer | ||
| path = /obj/item/stock_parts/circuitboard/radiocarbon_spectrometer | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New line here if you get the chance |
||
| /datum/fabricator_recipe/imprinter/circuit/holomap | ||
| path = /obj/item/stock_parts/circuitboard/holomap | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something specific for Persistence or could it go upstream eventually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it went upstream already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not unique to outreach, any dynamically loaded maps like away_sites would have that issue if they had elevators.