Skip to content

Network Finance saving#418

Merged
PsyCommando merged 4 commits intoPersistentSS13:devfrom
NataKilar:persistent-money
Mar 11, 2023
Merged

Network Finance saving#418
PsyCommando merged 4 commits intoPersistentSS13:devfrom
NataKilar:persistent-money

Conversation

@NataKilar
Copy link
Collaborator

Description of changes

Adds saved variables for network finance, with some adjustments. Fixes a few issues with flattened object and extension saving. Some diff noise in the _persistence.dme file due to automatic alphabetical sorting.

Authorship

Myself

@NataKilar NataKilar changed the title Persistent money Network Finance saving Mar 7, 2023
return should_save

//**Used to check if a movable will be saved by world save. */
/atom/movable/proc/will_save()
Copy link
Collaborator

@PsyCommando PsyCommando Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that proc for? It's a bit awkwardly named, and its description make it sound like it's identical to should_save() ?
Like what's the difference between that, and should_save()?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proc determines whether or not an atom will actually be saved during world save iteration, meaning it's either in a saved z-level or saved area. For example it is now used to determine if a mob will be saved by the world save or if it needs to be saved in limbo, and also used to determine if extensions should self-report for saving depending on whether or not their holder will save.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, but can you put that in the comments and give it a name that's a bit more representative of that? Like maybe "should_save_in_limbo", or something else?

@PsyCommando PsyCommando added the 🆕 enhancement New feature or request label Mar 8, 2023
@PsyCommando PsyCommando added this to the post open testing milestone Mar 8, 2023
@PsyCommando PsyCommando added the 💲 economy Things related to trading, currency, employment, costs. label Mar 9, 2023
Copy link
Collaborator

@PsyCommando PsyCommando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PsyCommando PsyCommando merged commit c8e2f21 into PersistentSS13:dev Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💲 economy Things related to trading, currency, employment, costs. 🆕 enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants